Date: Sat, 13 Jul 2002 16:03:58 +0200 From: Cyrille Lefevre <cyrille.lefevre@laposte.net> To: Alexander Leidinger <Alexander@Leidinger.net>, dwcjr@inethouston.net, freebsd-ports@FreeBSD.ORG Subject: Re: ports/39606: Updated port: audio/lame (3.92) Message-ID: <20020713140358.GA35227@gits.dyndns.org> In-Reply-To: <20020711025341.GD77112@gits.dyndns.org> References: <200207091650.g69Go6hU037888@freefall.freebsd.org> <200207092113.g69LDf1G045883@Magelan.Leidinger.net> <20020711025341.GD77112@gits.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
message resent due to mta misconfigation.
On Thu, Jul 11, 2002 at 04:53:41AM +0200, Cyrille Lefevre wrote:
> On Tue, Jul 09, 2002 at 11:13:41PM +0200, Alexander Leidinger wrote:
> > On 9 Jul, David W. Chapman Jr. wrote:
> > > The following reply was made to PR ports/39606; it has been noted by GNATS.
> > >
> > > From: "David W. Chapman Jr." <dwcjr@inethouston.net>
> > > To: freebsd-gnats-submit@FreeBSD.org, cyrille.lefevre@laposte.net
> > > Cc:
> > > Subject: Re: ports/39606: Updated port: audio/lame (3.92)
> > > Date: Tue, 09 Jul 2002 11:43:53 -0500
> > >
> > > What is the status of this pr?
> >
> > The port enables some parts of the code which even the CVS version of
> > LAME dosen't use. Cyrille hasn't answered after I complained about this.
>
> sorry, I though I answer you. also, I'm pretty busy right now...
> I even don't have the time to read the freebsd mailing-lists :(
>
> so, to go fast, I get rid of files/patch-libmp3lame::i386::Makefile,
> CONFIG_DEFS="${CONFIG_DEFS}" (in CONFIGURE_ENV+=) and
> CONFIG_DEFS= -DUSE_FFTSSE -DUSE_FFTFPU from the ports Makefile.
>
> to answer some of your questions :
>
> [about SSE, gogo, etc. ]
> > Did you benchmarked it?
> no, I can't since I only have a P200, so, no SSE, etc. maybe I'll
> find the time to do some tests later, but not right now.
>
> > [recent vorbis support]
> > Are you willing to produce patches for configure.in/Makefile.am ...
> what kind of patch ? vorbis rules already exists and there is
> nothing to do w/ the fact that you NEED the vorbis sources
> to build lame w/ vorbis support... this is absolutly non-standard.
> except if you want something like --with-vorbis-prefix-src= ?
> also, from version to version vorbis change ther "internal" API
> which is used by libmp3lame/vorbis_interface.c which need to be
> adapted everytime to seek vorbis. not my fault.
>
> [about the current version w/o SSE, gogo asm nor vorbis]
> make test give me this on my machine (P200)...
>
> time frontend/lame --nores -h ./testcase.wav testcase.new.mp3 || rm -f testcase.new.mp3
> LAME version 3.92 MMX (http://www.mp3dev.org/)
> CPU features: i387, MMX (ASM used)
> Using polyphase lowpass filter, transition band: 15115 Hz - 15648 Hz
> Encoding ./testcase.wav to testcase.new.mp3
> Encoding as 44.1 kHz 128 kbps j-stereo MPEG-1 Layer III (11x) qval=2
> Frame | CPU time/estim | REAL time/estim | play/CPU | ETA
> 21/23 (91%)| 0:01/ 0:01| 0:01/ 0:01| 0.5401x| 0:00
> average: 128.0 kbps LR: 5 (20.83%) MS: 19 (79.17%)
>
> Writing LAME Tag...done
> 1.22 real 1.04 user 0.02 sys
> cmp -l testcase.new.mp3 ./testcase.mp3 | wc -l
> 5
> where `cmp -l testcase.new.mp3 ./testcase.mp3' is :
> 78 100 112
> 103 200 212
> 128 300 312
> 191 110 12
> 192 13 351
>
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/ports/audio/lame/Makefile,v
> retrieving revision 1.21
> diff -u -r1.21 Makefile
> --- Makefile 22 Apr 2002 01:22:48 -0000 1.21
> +++ Makefile 11 Jul 2002 02:29:01 -0000
> @@ -6,40 +6,83 @@
> #
>
> PORTNAME= lame
> -PORTVERSION= 3.91
> +PORTVERSION= 3.92
> CATEGORIES= audio
> MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} \
> - ftp://lame.sourceforge.net/pub/
> + ftp://ftp.fu-berlin.de/unix/sound/%SUBDIR%/
> MASTER_SITE_SUBDIR= lame
>
> MAINTAINER= yoshiaki@kt.rim.or.jp
>
> BUILD_DEPENDS= nasm:${PORTSDIR}/devel/nasm
>
> +.if !defined(WITHOUT_VORBIS)
> +LIB_DEPENDS= vorbis.1:${PORTSDIR}/audio/libvorbis
> +
> +# libvorbis sources are required wether or not the library is already installed.
> +DEPENDS= ${PORTSDIR}/audio/libvorbis:patch
> +.endif
> +
> GNU_CONFIGURE= yes
> INSTALLS_SHLIB= yes
> +USE_GMAKE= yes
> +USE_LIBTOOL= yes
> WANT_GTK= yes
> -CONFIGURE_ARGS= --enable-nasm
> +CONFIGURE_ARGS= --enable-nasm --enable-mp3rtp
> +
> +MAN1= lame.1
>
> .include <bsd.port.pre.mk>
>
> -.if (defined(HAVE_GTK) || defined(WITH_GTK)) && !defined(WITHOUT_GTK)
> +.if defined(HAVE_GTK)
> USE_GTK= yes
> PLIST_SUB+= WITH_GTK=''
> +CONFIGURE_ARGS+= --enable-mp3x
> .else
> PLIST_SUB+= WITH_GTK='@comment '
> +CONFIGURE_ARGS+= --disable-gtktest
> .endif
>
> -MAN1= lame.1
> +.if !defined(WITHOUT_VORBIS)
> +LIBVORBIS_SRC!= cd ${PORTSDIR}/audio/libvorbis && ${MAKE} -V WRKSRC
>
> -post-build:
> -.if defined(HAVE_GTK) && !defined(WITHOUT_GTK)
> - (cd ${WRKSRC}/frontend && make mp3x)
> +CONFIGURE_ARGS+= --with-vorbis
> +CONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include -I${LIBVORBIS_SRC}/lib" \
> + LDFLAGS="-L${LOCALBASE}/lib" \
> + LIBS=-logg
> .endif
>
> -post-install:
> -.if defined(HAVE_GTK) && !defined(WITHOUT_GTK)
> - ${INSTALL_PROGRAM} ${WRKSRC}/frontend/mp3x ${PREFIX}/bin/
> +DOC_FILES= API LICENSE PRESETS.draft README TODO USAGE
> +
> +pre-everything::
> +.if !defined(WITHOUT_VORBIS)
> + @${ECHO_MSG}
> + @${ECHO_MSG} "If you don't want to compile with Vorbis support."
> + @${ECHO_MSG} "hit Ctrl-C right now and use \"make WITHOUT_VORBIS=yes\""
> + @${ECHO_MSG}
> .endif
> +
> +.if defined(NOPORTDOCS)
> +do-install:
> + @cd ${INSTALL_WRKSRC} && ${SETENV} ${MAKE_ENV} ${GMAKE} \
> + ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} install-exec
> + @cd ${INSTALL_WRKSRC}/include && ${SETENV} ${MAKE_ENV} ${GMAKE} \
> + ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} install-data
> + @cd ${INSTALL_WRKSRC}/doc/man && ${SETENV} ${MAKE_ENV} ${GMAKE} \
> + ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} install-data
> +
> +post-install: install-la
> +.else
> +post-install: install-la install-doc
> +
> +install-doc:
> + @${MKDIR} ${DOCSDIR}
> +.for file in ${DOC_FILES}
> + @${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR}
> +.endfor
> +.endif
> +
> +install-la:
> + @${INSTALL_SCRIPT} ${WRKSRC}/libmp3lame/libmp3lame.la ${PREFIX}/lib
>
> .include <bsd.port.post.mk>
>
> PS : I had some trouble these days w/ my mda configuration. for instance,
> I've solved them, but I've not finished some tests I'm doing regarding
> sendmail/mimedefang/spamassassin and some other anti-spam solutions such
> as tmda I need for my company... so, somethime I could send/receive emails,
> sometimes not (I even lost some of them a few days ago, grrr).
Cyrille.
--
Cyrille Lefevre mailto:cyrille.lefevre@laposte.net
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020713140358.GA35227>