Date: Thu, 6 Nov 2003 16:59:47 +0100 (CET) From: Simon Barner <barner@in.tum.de> To: FreeBSD-gnats-submit@FreeBSD.org Cc: oyvindmo@initio.no Subject: ports/59013: audio/ripit: Add http proxy support Message-ID: <20031106155947.454257E5@zi025.glhnet.mhn.de> Resent-Message-ID: <200311061600.hA6G0amt086327@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 59013 >Category: ports >Synopsis: audio/ripit: Add http proxy support >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Nov 06 08:00:36 PST 2003 >Closed-Date: >Last-Modified: >Originator: Simon Barner >Release: FreeBSD 4.9-PRERELEASE i386 >Organization: >Environment: System: FreeBSD zi025.glhnet.mhn.de 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #1: Thu Sep 4 20:49:53 CEST 2003 simon@zi025.glhnet.mhn.de:/usr/src/sys/compile/KISTE i386 >Description: This makes ripit use a http proxy if the HTTP_PROXY environment variable is set. Please test this also with non-proxy http und plain cddb mode - I cannot do that since I am behind a rigid firewall (hence the patch :-) I have also mailed the (tiny) diff to the author of the script. >How-To-Repeat: N/A >Fix: --- files/patch-aa.orig Thu Nov 6 16:53:42 2003 +++ files/patch-aa Thu Nov 6 16:54:00 2003 @@ -1,5 +1,11 @@ ---- ripit.pl.orig Sat Aug 25 18:20:06 2001 -+++ ripit.pl Fri May 24 14:16:20 2002 +--- ripit.pl.orig Thu Nov 6 16:53:13 2003 ++++ ripit.pl Thu Nov 6 16:53:23 2003 +@@ -1,4 +1,4 @@ +-#!/usr/bin/perl ++#!/usr/local/bin/perl + # + # ripit.pl - Rips CD Audio and creates MP3 files + # Does the following: @@ -9,41 +9,47 @@ # Create an M3U file # @@ -132,7 +138,17 @@ # # Create the track selection from the parameters passed # on the command line -@@ -280,7 +302,6 @@ +@@ -206,7 +228,8 @@ + + #Configure CDDB_get parameters + $config{CDDB_HOST} = $CDDB_HOST; +- $config{CDDB_PORT} = $CDDB_PORT; ++ $config{CDDB_PORT} = $CDDB_PORT; ++ $config{HTTP_PROXY}=$ENV{http_proxy} if $ENV{http_proxy}; # Use proxy if available + $config{CDDB_MODE} = $CDDB_MODE; + $config{CD_DEVICE} = $cddev; + $config{input} = $CDDB_INPUT; +@@ -280,7 +303,6 @@ # sub create_dirs { # Directory created will be: /outputdir/Artist - Album/ @@ -140,7 +156,7 @@ $mp3dir = $outputdir.$artist." - ".$album."/"; -@@ -336,31 +357,37 @@ +@@ -336,31 +358,37 @@ $riptrackname = &get_trackname($_, $tracklist[$_ - 1]); $riptrackno = $_; @@ -182,7 +198,7 @@ } } elsif ($cdripper == 4) { -@@ -369,9 +396,37 @@ +@@ -369,9 +397,37 @@ $cdd_dev =~ s/c$//; if (system("cdd -t $riptrackno -q -f $cdd_dev - 2>/dev/null | sox -t cdr -x - \"$riptrackname.rip\"")) { &printflush(RIPLOG,"cdd failed on $tracklist[$_ - 1]\n"); @@ -220,7 +236,7 @@ else { die "No CD Ripper defined"; } -@@ -381,11 +436,13 @@ +@@ -381,11 +437,13 @@ rename "$riptrackname.rip","$riptrackname.wav"; &printflush(RIPLOG,"Rip complete $tracklist[$_ - 1]\n"); @@ -238,7 +254,7 @@ } } -@@ -407,24 +464,37 @@ +@@ -407,24 +465,37 @@ $riptrackno = $_; $ncount++; @@ -281,7 +297,7 @@ } if ( ! system("$enc >$enclog 2>&1 </dev/null")) { -@@ -438,7 +508,8 @@ +@@ -438,7 +509,8 @@ &printflush(RIPLOG,"MP3 Encoder Failed on $tracklist[$_ - 1]\n"); die "MP3 Encoder Failed on $tracklist[$_ - 1]"; } @@ -291,7 +307,7 @@ } exit ; } -@@ -452,10 +523,10 @@ +@@ -452,10 +524,10 @@ $file="$artist.m3u"; if ($use_underscore == 1) { $file =~ s/ /_/g; } >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031106155947.454257E5>