Date: Fri, 22 May 2015 21:09:11 +0000 (UTC) From: Neel Natu <neel@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r283299 - head/sys/amd64/vmm Message-ID: <201505222109.t4ML9BxM070139@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: neel Date: Fri May 22 21:09:11 2015 New Revision: 283299 URL: https://svnweb.freebsd.org/changeset/base/283299 Log: Remove the verification of instruction length after instruction decode. The check has been bogus since r273375. MFC after: 1 week Modified: head/sys/amd64/vmm/vmm_instruction_emul.c Modified: head/sys/amd64/vmm/vmm_instruction_emul.c ============================================================================== --- head/sys/amd64/vmm/vmm_instruction_emul.c Fri May 22 21:04:42 2015 (r283298) +++ head/sys/amd64/vmm/vmm_instruction_emul.c Fri May 22 21:09:11 2015 (r283299) @@ -2315,19 +2315,6 @@ decode_moffset(struct vie *vie) } /* - * Verify that all the bytes in the instruction buffer were consumed. - */ -static int -verify_inst_length(struct vie *vie) -{ - - if (vie->num_processed) - return (0); - else - return (-1); -} - -/* * Verify that the 'guest linear address' provided as collateral of the nested * page table fault matches with our instruction decoding. */ @@ -2408,9 +2395,6 @@ vmm_decode_instruction(struct vm *vm, in if (decode_moffset(vie)) return (-1); - if (verify_inst_length(vie)) - return (-1); - if ((vie->op.op_flags & VIE_OP_F_NO_GLA_VERIFICATION) == 0) { if (verify_gla(vm, cpuid, gla, vie)) return (-1);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201505222109.t4ML9BxM070139>