Date: Tue, 4 Feb 2014 21:09:59 +0100 From: Tijl Coosemans <tijl@FreeBSD.org> To: Koop Mast <kwm@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r342587 - head/x11/pixman Message-ID: <20140204210959.044bc79a@kalimero.tijl.coosemans.org> In-Reply-To: <201402041839.s14IdgAF097754@svn.freebsd.org> References: <201402041839.s14IdgAF097754@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Feb 2014 18:39:42 +0000 (UTC) Koop Mast wrote: > Author: kwm > Date: Tue Feb 4 18:39:42 2014 > New Revision: 342587 > URL: http://svnweb.freebsd.org/changeset/ports/342587 > QAT: https://qat.redports.org/buildarchive/r342587/ > > Log: > Fix SIMD check, and only check MACHINE_CPU if it is defined. > > Modified: > head/x11/pixman/Makefile > > Modified: head/x11/pixman/Makefile > ============================================================================== > --- head/x11/pixman/Makefile Tue Feb 4 18:35:58 2014 (r342586) > +++ head/x11/pixman/Makefile Tue Feb 4 18:39:42 2014 (r342587) > @@ -18,14 +18,16 @@ OPTIONS_DEFINE= SIMD > > .include <bsd.port.options.mk> > > -.if ! {PORT_OPTIONS:MSIMD} > +.if ! ${PORT_OPTIONS:MSIMD} > CONFIGURE_ARGS= --disable-vmx --disable-arm-simd > +. if defined(MACHINE_CPU) > . if ! ${MACHINE_CPU:Mmmx} > CONFIGURE_ARGS+= --disable-mmx > . endif > . if ! ${MACHINE_CPU:Msse2} > CONFIGURE_ARGS+= --disable-sse2 > . endif > +. endif > .endif > > .include <bsd.port.mk> The is a bit strange because if you turn off SIMD you still get MMX and SSE2 support if your cpu supports it. It should be something like this: .if ! ${PORT_OPTIONS:MSIMD} CONFIGURE_ARGS= --disable-vmx --disable-arm-simd --disable-mmx \ --disable-sse2 .endif But then you're still missing --disable-ssse3 and a number of ARM and MIPS SIMD options (reported by ./configure --help). I think it's best to just remove this whole block together with the SIMD option because pixman tests at runtime what features the cpu supports so in my opinion there's no reason to disable SIMD support. Or at the very least turn SIMD on by default. The current i386 package of pixman has SSSE3 support but not MMX or SSE2 which makes no sense: checking whether to use MMX intrinsics... disabled checking whether to use SSE2 intrinsics... disabled checking whether to use SSSE3 intrinsics... yes http://beefy1.isc.freebsd.org/bulk/head-i386-default/2014-01-23_09h31m52s/logs/pixman-0.32.4.log
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140204210959.044bc79a>