Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 5 Dec 2010 10:15:23 +0000 (UTC)
From:      Ed Schouten <ed@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r216198 - head/sys/teken
Message-ID:  <201012051015.oB5AFNEQ082881@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ed
Date: Sun Dec  5 10:15:23 2010
New Revision: 216198
URL: http://svn.freebsd.org/changeset/base/216198

Log:
  Use proper bounds checking on VPA.
  
  We must check against tp->t_cursor.tp_row, not row, to figure out
  whether we must clamp the cursor position.
  
  Submitted by:	luigi
  MFC after:	3 weeks

Modified:
  head/sys/teken/teken_subr.h

Modified: head/sys/teken/teken_subr.h
==============================================================================
--- head/sys/teken/teken_subr.h	Sun Dec  5 09:35:07 2010	(r216197)
+++ head/sys/teken/teken_subr.h	Sun Dec  5 10:15:23 2010	(r216198)
@@ -1299,10 +1299,9 @@ teken_subr_vertical_position_absolute(te
 {
 
 	t->t_cursor.tp_row = t->t_originreg.ts_begin + row - 1;
-	if (row >= t->t_originreg.ts_end)
+	if (t->t_cursor.tp_row >= t->t_originreg.ts_end)
 		t->t_cursor.tp_row = t->t_originreg.ts_end - 1;
 
-
 	t->t_stateflags &= ~TS_WRAPPED;
 	teken_funcs_cursor(t);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012051015.oB5AFNEQ082881>