Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 04 Feb 2014 21:31:32 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Max Brazhnikov <makc@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r342510 - head/games/cutemaze
Message-ID:  <F8B0618EB2ADCB61C5A7F77E@atuin.in.mat.cc>
In-Reply-To: <7443970.95gMSVNHBu@mercury.ph.man.ac.uk>
References:  <201402041149.s14BnPX0031911@svn.freebsd.org> <3033718.ko1yqU3EN4@mercury.ph.man.ac.uk> <36D80F89A7D5FF449E4FCBDF@ogg.in.absolight.net> <7443970.95gMSVNHBu@mercury.ph.man.ac.uk>

next in thread | previous in thread | raw e-mail | index | archive | help
+--On 4 f=C3=A9vrier 2014 20:08:50 +0000 Max Brazhnikov <makc@freebsd.org>
wrote:
| On Tue, 04 Feb 2014 17:31:39 +0100 Mathieu Arnold wrote:
|> Most substitutions are right, I mean, in a perl port, I want PERL_VER,
|> and SITE_PERL, and PERL5_MAN3, and... there are a few like QT_BINDIR
|> which shouldn't go in it, but it feels more like having a blacklist than
|> a whitelist.
|=20
| Blacklist can be longer than whitelist :).

Remains to be seen :-)

| I'll think about it. The problem is not specific to Qt ports. I've
| already been beaten when KDE4_VERSION was improperly used for library
| version (just coincidence). In fact, QT_BINDIR could be easily hidden for
| other ports, but I'd like to see general solution.

Well, I was considering removing macros with only 1 and 2 caracters, I
don't remember why I did not.

--=20
Mathieu Arnold



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F8B0618EB2ADCB61C5A7F77E>