Date: Wed, 28 Apr 2010 04:57:19 -0700 From: Randall Stewart <rrs@lakerest.net> To: Rui Paulo <rpaulo@freebsd.org> Cc: freebsd-mips@freebsd.org Subject: Re: [PATCH] Account RMI XLR interrupts Message-ID: <921B6E11-9919-4674-B7A2-71EB3A22B2EB@lakerest.net> In-Reply-To: <13B981BB-EDB1-4D39-A9CA-A1D4981E5732@freebsd.org> References: <BAAA25BC-6094-4B5B-9C83-A330933EBA51@freebsd.org> <13B981BB-EDB1-4D39-A9CA-A1D4981E5732@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Rui:
Let me commit the whole works when I get back to CA..
That won't be until a week from Sunday... unless your
desperate to get this in..
I was hoping to get to the bottom of the other SMP crash I see
before dumping all of JC's patches in..
But if you need this badly enough go ahead...
R
On Apr 28, 2010, at 4:28 AM, Rui Paulo wrote:
>
> On 20 Apr 2010, at 12:36, Rui Paulo wrote:
>
>> Hi,
>> The following patch accounts interrupts on the XLR and makes vmstat
>> -i and systat work display useful data. I think the commented out
>> atomic inc can go away, but I'm not sure.
>>
>> Here's an example:
>>
>> $ vmstat -i
>> interrupt total rate
>> int16: 56118 984
>> int17: 214 3
>> Total 56332 988
>>
>> int16 is the timer and int17 is the network interface (rge1).
>>
>> Index: intr_machdep.c
>> ===================================================================
>> --- intr_machdep.c (revision 206791)
>> +++ intr_machdep.c (working copy)
>> @@ -157,28 +157,17 @@
>> for (i = sizeof(eirr) * 8 - 1; i >= 0; i--) {
>> if ((eirr & (1ULL << i)) == 0)
>> continue;
>> ie = mips_intr_events[i];
>> /* atomic_add_long(mih->cntp, 1); */
>> + /* Don't account special IRQs */
>> + switch (i) {
>> + case IRQ_IPI:
>> + case IRQ_MSGRING:
>> + break;
>> + default:
>> + mips_intrcnt_inc(mips_intr_counters[i]);
>> + }
>>
>> write_c0_eirr64(1ULL << i);
>> pic_ack(i, 0);
>>
>
> Can I commit this?
>
> Regards,
> --
> Rui Paulo
>
>
> _______________________________________________
> freebsd-mips@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-mips
> To unsubscribe, send any mail to "freebsd-mips-
> unsubscribe@freebsd.org"
>
------------------------------
Randall Stewart
803-317-4952 (cell)
803-345-0391(direct)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?921B6E11-9919-4674-B7A2-71EB3A22B2EB>