Date: Wed, 23 Sep 2015 08:40:33 -0700 From: Adrian Chadd <adrian.chadd@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: freebsd-net <freebsd-net@freebsd.org>, "George V. Neville-Neil" <gnn@freebsd.org> Subject: Re: page fault in tcp_do_segment (r287759 suspected) Message-ID: <CAJ-VmokCkV4-6f-s=Usb3mkP5oe9%2BiL2McxDprM8tNwUuDnwCA@mail.gmail.com> In-Reply-To: <560250B9.3080002@FreeBSD.org> References: <56011276.4060206@FreeBSD.org> <560250B9.3080002@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yes, file a bug. :) -a On 23 September 2015 at 00:11, Andriy Gapon <avg@freebsd.org> wrote: > On 22/09/2015 11:33, Andriy Gapon wrote: >> That code actually looks like the following DTrace probe a few lines below: >> >> TCP_PROBE3(debug__input, tp, th, mtod(m, const char *)); >> >> So, it seems like 'm' could be NULL here. >> I see two places in tcp_do_segment() where m gets assigned with NULL followed by >> goto drop. If I had to guess then my guess would be that one of those code >> paths was taken. >> Since those NULL assignments were there for more than a year, then I would guess >> that the addition of the probe is to blame: >> https://svnweb.freebsd.org/base?view=revision&revision=287759 > > Should I file a bug report about this? > Does anyone has suggestion for a simple fix? > > -- > Andriy Gapon > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokCkV4-6f-s=Usb3mkP5oe9%2BiL2McxDprM8tNwUuDnwCA>