Date: Tue, 24 Apr 2001 12:25:08 -0700 From: Alfred Perlstein <bright@wintelcom.net> To: Terry Lambert <tlambert@primenet.com> Cc: current@FreeBSD.ORG, terry@lambert.org Subject: Re: PATCH to make maxfiles, maxfiles per proc boot-time tunable Message-ID: <20010424122508.U1790@fw.wintelcom.net> In-Reply-To: <200104241859.LAA02506@usr08.primenet.com>; from tlambert@primenet.com on Tue, Apr 24, 2001 at 06:59:38PM %2B0000 References: <200104241859.LAA02506@usr08.primenet.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* Terry Lambert <tlambert@primenet.com> [010424 11:59] wrote:
> It seems to me that these things are not boot-time tunable, and
> should be (really, they should be runtime tunable, but there
> are some nasty pageable region allocations for networking that
> appear to require contiguous regions for no good reason which I
> can discern). That means that the best we can do right now is
> boot-time, so here it is:
This looks good except that ncallout is still based on MAXFILES,
without this being fixed I think people might get bitten by
raising the tuneable too high then being unable to allocate
enough callouts. Can you take a look at this and make sure there's
nothing else using MAXFILES like that?
>
>
> --------------------------------------------------------------------------
> Index: conf/param.c
> ===================================================================
> RCS file: /home/cvs/local_repo/FreeBSD/sys.releng4/conf/param.c,v
> retrieving revision 1.1.1.1
> diff -c -r1.1.1.1 param.c
> *** conf/param.c 2001/03/21 00:50:42 1.1.1.1
> --- conf/param.c 2001/04/19 20:57:59
> ***************
> *** 44,49 ****
> --- 44,51 ----
> #include "opt_param.h"
>
> #include <sys/param.h>
> + #include <sys/systm.h> /* getenv_int */
> + #include <sys/kernel.h> /* TUNABLE_INT_DECL */
>
> /*
> * System parameter formulae.
> ***************
> *** 67,74 ****
> #endif
> int maxproc = NPROC; /* maximum # of processes */
> int maxprocperuid = NPROC-1; /* maximum # of processes per user */
> ! int maxfiles = MAXFILES; /* system wide open files limit */
> ! int maxfilesperproc = MAXFILES; /* per-process open files limit */
> int ncallout = 16 + NPROC + MAXFILES; /* maximum # of timer events */
> int mbuf_wait = 32; /* mbuf sleep time in ticks */
>
> --- 69,78 ----
> #endif
> int maxproc = NPROC; /* maximum # of processes */
> int maxprocperuid = NPROC-1; /* maximum # of processes per user */
> ! int maxfiles = 0; /* system wide open files limit */
> ! TUNABLE_INT_DECL("kern.maxfiles", MAXFILES, maxfiles);
> ! int maxfilesperproc = 0; /* per-process open files limit */
> ! TUNABLE_INT_DECL("kern.maxfilesperproc", MAXFILES, maxfilesperproc);
> int ncallout = 16 + NPROC + MAXFILES; /* maximum # of timer events */
> int mbuf_wait = 32; /* mbuf sleep time in ticks */
>
> --------------------------------------------------------------------------
>
>
> Terry Lambert
> terry@lambert.org
> ---
> Any opinions in this posting are my own and not those of my present
> or previous employers.
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
--
-Alfred Perlstein - [alfred@freebsd.org]
Instead of asking why a piece of software is using "1970s technology,"
start asking why software is ignoring 30 years of accumulated wisdom.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010424122508.U1790>