Date: Fri, 5 Jul 2013 00:03:54 +0000 (UTC) From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r252736 - head/sys/net80211 Message-ID: <201307050003.r6503sD8000391@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adrian Date: Fri Jul 5 00:03:53 2013 New Revision: 252736 URL: http://svnweb.freebsd.org/changeset/base/252736 Log: Document the current 11n rate selection shortcoming in the AMRR code. Modified: head/sys/net80211/ieee80211_amrr.c Modified: head/sys/net80211/ieee80211_amrr.c ============================================================================== --- head/sys/net80211/ieee80211_amrr.c Thu Jul 4 23:08:27 2013 (r252735) +++ head/sys/net80211/ieee80211_amrr.c Fri Jul 5 00:03:53 2013 (r252736) @@ -240,6 +240,14 @@ amrr_update(struct ieee80211_amrr *amrr, amn->amn_txcnt, amn->amn_retrycnt); + /* + * XXX This is totally bogus for 11n, as although high MCS + * rates for each stream may be failing, the next stream + * should be checked. + * + * Eg, if MCS5 is ok but MCS6/7 isn't, and we can go up to + * MCS23, we should skip 6/7 and try 8 onwards. + */ if (is_success(amn)) { amn->amn_success++; if (amn->amn_success >= amn->amn_success_threshold &&
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307050003.r6503sD8000391>