Date: Thu, 12 Jun 2008 23:20:35 -0500 From: Stephen Montgomery-Smith <stephen@math.missouri.edu> To: freebsd-hackers@freebsd.org Subject: Small change to top Message-ID: <4851F593.2030504@math.missouri.edu>
next in thread | raw e-mail | index | archive | help
top doesn't get TIME right for threaded processes. How about this small
change:
--- usr.bin/top/machine.c-orig 2008-06-12 23:06:08.000000000 -0500
+++ usr.bin/top/machine.c 2008-06-12 23:06:51.000000000 -0500
@@ -725,6 +725,7 @@
prev_pp = pp;
} else {
prev_pp->ki_pctcpu += pp->ki_pctcpu;
+ prev_pp->ki_runtime += pp->ki_runtime;
}
}
(Sorry if the mail client messes up the patch, but it is so short that
it can be easily entered by hand.)
I do realize that this is not foolproof, because it won't measure any
threads that have finished. But it is perhaps a bit better than the
current state of affairs, which randomly picks a runtime of one of the
threads.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4851F593.2030504>