Date: Wed, 19 Nov 2003 20:02:11 -0500 (EST) From: James Housley <jeh@vaio2.int.thehousleys.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/59493: The ports system doesn't or can't honor NO_CPU_CFLAGS Message-ID: <200311200102.hAK12BYA076404@vaio2.int.thehousleys.net> Resent-Message-ID: <200311200230.hAK2UEYu049697@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 59493
>Category: ports
>Synopsis: The ports system doesn't or can't honor NO_CPU_CFLAGS
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Nov 19 18:30:14 PST 2003
>Closed-Date:
>Last-Modified:
>Originator: James Housley
>Release: FreeBSD 4.9-RELEASE i386
>Organization:
>Environment:
System: FreeBSD vaio2.int.thehousleys.net 4.9-RELEASE FreeBSD 4.9-RELEASE #20: Mon Oct 27 08:48:54 EST 2003 root@cat.int.thehousleys.net:/usr/obj/usr/src/sys/VAIOKERNEL i386
>Description:
It is not possible to set NO_CPU_CFLAGS in a ports makefile
and not have -mcpu or -march in the CFLAGS if NO_CPU_CFLAGS
is not specified in /etc/make.conf. I believe this is
becuase they have already been added before the ports makefile
and Mk/* files are parsed.
>How-To-Repeat:
>Fix:
--- diff.txt begins here ---
Index: bsd.port.mk
===================================================================
RCS file: /usr/FREEBSD_CVS/ports/Mk/bsd.port.mk,v
retrieving revision 1.473
diff -u -r1.473 bsd.port.mk
--- bsd.port.mk 8 Nov 2003 03:22:08 -0000 1.473
+++ bsd.port.mk 20 Nov 2003 00:56:56 -0000
@@ -1179,6 +1179,10 @@
PLIST_SUB+= OSREL=${OSREL} PREFIX=%D LOCALBASE=${LOCALBASE} X11BASE=${X11BASE}
+.if defined(NO_CPU_CFLAGS)
+CFLAGS:= ${CFLAGS:C/${_CPUCFLAGS}//}
+.endif
+
.if defined(NOPORTDOCS)
PLIST_SUB+= PORTDOCS="@comment "
.else
--- diff.txt ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200311200102.hAK12BYA076404>