Date: Tue, 29 Apr 2014 05:11:36 GMT
From: Jia-Shiun Li <jiashiun@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ports/189096: [patch] make multimedia/gstreamer{, 1}-plugins-{good, bad, ugly} respect ${_MAKE_JOBS} of bsd.port.mk
Message-ID: <201404290511.s3T5BaHR076676@cgiserv.freebsd.org>
Resent-Message-ID: <201404290520.s3T5K1X3072743@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 189096
>Category: ports
>Synopsis: [patch] make multimedia/gstreamer{,1}-plugins-{good,bad,ugly} respect ${_MAKE_JOBS} of bsd.port.mk
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Apr 29 05:20:01 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Jia-Shiun Li
>Release: 11.0-CURRENT
>Organization:
>Environment:
FreeBSD 4cbsd 11.0-CURRENT FreeBSD 11.0-CURRENT #31 r264726: Tue Apr 22 01:19:28 CST 2014 jsli@4cbsd:/usr/obj/usr/src/sys/Minimal amd64
>Description:
multimedia/gstreamer{,1}-plugins-{good,bad,ugly} have their own do-build targets since long ago and did not catch the MAKE_JOBS_* ports infrastructure update. So they do not make good use of multi-core CPUs on modern machines.
This patch brings these ports in line with others to use ${_MAKE_JOBS} flags when calling ${GMAKE}.
The end result is faster build on multi-core machines.
>How-To-Repeat:
>Fix:
patch attached.
Patch attached with submission follows:
--- gstreamer-plugins-good.orig/Makefile 2014-04-25 20:46:45.000000000 +0800
+++ gstreamer-plugins-good/Makefile 2014-04-29 12:10:37.000000000 +0800
@@ -26,7 +26,7 @@
do-build:
.for dir in ${GOOD_GST_DIRS}
- @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} ${ALL_TARGET})
+ @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${_MAKE_JOBS} ${MAKE_ARGS} ${ALL_TARGET})
.endfor
do-install:
--- gstreamer-plugins-ugly.orig/Makefile 2014-04-25 20:46:45.000000000 +0800
+++ gstreamer-plugins-ugly/Makefile 2014-04-29 12:11:02.000000000 +0800
@@ -23,7 +23,7 @@
do-build:
.for dir in ${UGLY_GST_DIRS}
- @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} ${ALL_TARGET})
+ @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${_MAKE_JOBS} ${MAKE_ARGS} ${ALL_TARGET})
.endfor
do-install:
--- gstreamer-plugins-bad.orig/Makefile 2014-04-25 20:46:45.000000000 +0800
+++ gstreamer-plugins-bad/Makefile 2014-04-29 12:10:51.000000000 +0800
@@ -24,7 +24,7 @@
do-build:
.for dir in ${BAD_GST_DIRS}
- @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} ${ALL_TARGET})
+ @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${_MAKE_JOBS} ${MAKE_ARGS} ${ALL_TARGET})
.endfor
do-install:
--- gstreamer1-plugins-good.orig/Makefile 2014-04-23 22:22:47.000000000 +0800
+++ gstreamer1-plugins-good/Makefile 2014-04-29 12:11:10.000000000 +0800
@@ -27,7 +27,7 @@
do-build:
.for dir in ${GOOD_GST_DIRS}
- @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} ${ALL_TARGET})
+ @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${_MAKE_JOBS} ${MAKE_ARGS} ${ALL_TARGET})
.endfor
do-install:
--- gstreamer1-plugins-ugly.orig/Makefile 2014-04-23 22:22:47.000000000 +0800
+++ gstreamer1-plugins-ugly/Makefile 2014-04-29 12:11:29.000000000 +0800
@@ -22,7 +22,7 @@
do-build:
.for dir in ${UGLY_GST_DIRS}
- @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} ${ALL_TARGET})
+ @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${_MAKE_JOBS} ${MAKE_ARGS} ${ALL_TARGET})
.endfor
do-install:
--- gstreamer1-plugins-bad.orig/Makefile 2014-04-23 22:22:47.000000000 +0800
+++ gstreamer1-plugins-bad/Makefile 2014-04-29 12:11:20.000000000 +0800
@@ -23,7 +23,7 @@
do-build:
.for dir in ${BAD_GST_DIRS}
- @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} ${ALL_TARGET})
+ @(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} ${MAKEFILE} ${_MAKE_JOBS} ${MAKE_ARGS} ${ALL_TARGET})
.endfor
do-install:
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404290511.s3T5BaHR076676>