Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Jan 2014 22:33:49 +0000 (UTC)
From:      Devin Teske <dteske@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r260866 - head/usr.sbin/bsdinstall/scripts
Message-ID:  <201401182233.s0IMXn1h075062@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dteske
Date: Sat Jan 18 22:33:49 2014
New Revision: 260866
URL: http://svnweb.freebsd.org/changeset/base/260866

Log:
  Fix a bad comparison operator (s/==/=/), and address a use-case issue where-
  in the one-line comment associated with the dumpdev setting was not present
  for the case where the user deselects the dumpdev service (restoring pre-
  r256348 behaviour.
  
  MFC After:	3 days

Modified:
  head/usr.sbin/bsdinstall/scripts/services

Modified: head/usr.sbin/bsdinstall/scripts/services
==============================================================================
--- head/usr.sbin/bsdinstall/scripts/services	Sat Jan 18 22:32:48 2014	(r260865)
+++ head/usr.sbin/bsdinstall/scripts/services	Sat Jan 18 22:33:49 2014	(r260866)
@@ -52,16 +52,14 @@ exec 3>&-
 
 havedump=
 for daemon in $DAEMONS; do
-	if [ "$daemon" == "dumpdev" ]; then
-		havedump=1
-		echo '# Set dumpdev to "AUTO" to enable crash dumps, "NO"' \
-		     'to disable' >> $BSDINSTALL_TMPETC/rc.conf.services
-		echo dumpdev=\"AUTO\" >> $BSDINSTALL_TMPETC/rc.conf.services
-		continue
-	fi
+	[ "$daemon" = "dumpdev" ] && havedump=1 continue
 	echo ${daemon}_enable=\"YES\" >> $BSDINSTALL_TMPETC/rc.conf.services
 done
 
-if [ ! "$havedump" ]; then
+echo '# Set dumpdev to "AUTO" to enable crash dumps, "NO"' \
+     'to disable' >> $BSDINSTALL_TMPETC/rc.conf.services
+if [ "$havedump" ]; then
+	echo dumpdev=\"AUTO\" >> $BSDINSTALL_TMPETC/rc.conf.services
+else
 	echo dumpdev=\"NO\" >> $BSDINSTALL_TMPETC/rc.conf.services
 fi



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401182233.s0IMXn1h075062>