Skip site navigation (1)Skip section navigation (2)
Date:      Fri,  1 Nov 2002 19:56:32 -0500 (EST)
From:      parv <parv_fm@emailgroups.net>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/44820: x11-wm/fvwm2-devel - PATCH to take care of a nasty pager problem
Message-ID:  <20021102005632.87FE6B967@moo.holy.cow>

next in thread | raw e-mail | index | archive | help

>Number:         44820
>Category:       ports
>Synopsis:       x11-wm/fvwm2-devel - PATCH to take care of a nasty pager problem
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 01 17:00:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     parv
>Release:        FreeBSD 4.7-RELEASE i386
>Organization:
>Environment:
System: FreeBSD moo.holy.cow 4.7-RELEASE

fvwm 2.5.4

>Description:

with the following minimum custom configuration file, FvwmPager uses
near 100% CPU...
           
  AddToFunc StartFunction
  + I Module FvwmPager * *
      
  DeskTopSize  2x2
        
  DestroyModuleConfig FvwmPager: *
  *FvwmPager: NoSeparators


...for more details see...

  http://www.hpc.uh.edu/fvwm/archive/0211/msg00000.html


>How-To-Repeat:

use fvwm 2.5.4 w/ above config file & see CPU use jump to 100%


>Fix:

below is the patch generated from differences in x_pager.c versions
in fvwm cvs & freebsd fvwm 2.5.4 port...


--- modules/FvwmPager/x_pager.c.old	Thu Oct 24 00:46:59 2002
+++ modules/FvwmPager/x_pager.c	Fri Nov  1 19:26:11 2002
@@ -1630,8 +1630,8 @@
 				XDrawLine(
 					dpy,Desks[desk].w,Desks[desk].DashedGC,
 					x1,y1,x1,y2);
-				x += Scr.MyDisplayWidth;
 			}
+			x += Scr.MyDisplayWidth;
 		}
 		y = Scr.MyDisplayHeight;
 		x1 = 0;
@@ -1640,9 +1640,11 @@
 		{
 			y1 = (y * desk_h) / Scr.VHeight;
 			if (!use_no_separators)
+			{
 				XDrawLine(
 					dpy,Desks[desk].w,Desks[desk].DashedGC,
 					x1,y1,x2,y1);
+			}
 			y += Scr.MyDisplayHeight;
 		}
 	}


>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021102005632.87FE6B967>