Date: Thu, 25 Sep 2003 15:09:35 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Bernd Walter <ticso@cicely12.cicely.de> Cc: hackers@freebsd.org Subject: Re: PCI bridges & interrupts Message-ID: <XFMail.20030925150935.jhb@FreeBSD.org> In-Reply-To: <20030925135456.GK90598@cicely12.cicely.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25-Sep-2003 Bernd Walter wrote:
> On Wed, Sep 24, 2003 at 06:17:43PM -0400, John Baldwin wrote:
>>
>> On 24-Sep-2003 M. Warner Losh wrote:
>> > You might want to make sure that you have an up to date stable. There
>> > was a fix to the PCI bridge interrupt swizzle.
>>
>> Ah yes, that's true. However, it doesn't seem that his interrupt is
>> being routed, but I could be wrong. Also, there is another bug in the
>> $PIR handling that I committed at BSDCon that also might fix the
>> problem.
>
> Is your $PIR fix for the everthing gets IRQ4 case?
Well, when using 'pci_cfgintr_linked' we would get things wrong.
> lcvs diff -u -kk -r1.104 -r1.105 pci_cfgreg.c
Index: pci_cfgreg.c
===================================================================
RCS file: /usr/cvs/src/sys/i386/pci/pci_cfgreg.c,v
retrieving revision 1.104
retrieving revision 1.105
diff -u -r1.104 -r1.105
--- pci_cfgreg.c 2 Aug 2003 05:14:17 -0000 1.104
+++ pci_cfgreg.c 10 Sep 2003 06:00:53 -0000 1.105
@@ -445,7 +445,7 @@
* table entry
*/
irq = pci_cfgintr_search(pe, oe->pe_bus, oe->pe_device,
- j, pin);
+ j + 1, pin);
if (irq != PCI_INVALID_IRQ)
return(irq);
}
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030925150935.jhb>