Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 9 Dec 2016 15:09:54 +1100
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        Rene Ladan <rene@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r428154 - head/www/py-formalchemy
Message-ID:  <b4ad06ce-138b-c324-f3ae-a06e4ac86cd4@FreeBSD.org>
In-Reply-To: <201612082012.uB8KCqUv054897@repo.freebsd.org>
References:  <201612082012.uB8KCqUv054897@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 9/12/2016 7:12 AM, Rene Ladan wrote:
>  PORTNAME=	formalchemy
> -PORTVERSION=	1.3.3
> -PORTREVISION=	2
> +PORTVERSION=	1.5.1

PyPI (CHEESESHOP) has 1.5.5

https://pypi.python.org/pypi/FormAlchemy

>  CATEGORIES=	www python
> -MASTER_SITES=	GOOGLE_CODE
> +#MASTER_SITES=	https://github.com/FormAlchemy/formalchemy

This can be removed (but switch this to CHEESESHOP instead given it has
a later version)

>  PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
>  DISTNAME=	FormAlchemy-${DISTVERSION}
>  
> @@ -14,11 +13,11 @@ COMMENT=	Toolkit for creating HTML form 
>  
>  LICENSE=	MIT

There is a LICENSE_FILE (COPYRIGHT.TXT) in WKRSRC (both PyPI and
Github), please add it when one exists there.

>  
> -BROKEN=		Unfetchable (google code has gone away)
> -DEPRECATED=	Broken, depends on expired py-sqlalchemy06
> -EXPIRATION_DATE=	2016-12-08
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	FormAlchemy
> +GH_TAGNAME=	v${PORTVERSION}

Use DISTVERSIONPREFIX=v instead of this (when using USE_GITHUB) and tags
begin with 'v'.
>  
> -BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}sqlalchemy06>=0.4.5:databases/py-sqlalchemy06 \
> +BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}sqlalchemy10>=0.4.5:databases/py-sqlalchemy10 \
>  		${PYTHON_PKGNAMEPREFIX}Tempita>=0.4:textproc/py-Tempita \
>  		${PYTHON_PKGNAMEPREFIX}webhelpers>=0.6.4:www/py-webhelpers

None of these are BUILD_DEPENDS (ie; setup.py:setup_requires) [1]

>  RUN_DEPENDS:=	${BUILD_DEPENDS}

* They are all RUN_DEPENDS (ie; setup.py:install_requires) [1]
* MarkupSafe and six are missing from RUN_DEPENDS [1]

[1] setup.py: install_requires=['SQLAlchemy', 'Tempita', 'WebHelpers2',
'WebOb', 'MarkupSafe', 'six'],

See also: https://github.com/FormAlchemy/formalchemy/issues/69 as a
backported commit may be required.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b4ad06ce-138b-c324-f3ae-a06e4ac86cd4>