Date: Tue, 25 Dec 2012 13:28:20 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Alfred Perlstein <bright@mu.org> Cc: svn-src-stable@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r244663 - stable/9 Message-ID: <20121225112820.GC53644@kib.kiev.ua> In-Reply-To: <20121225104422.GB53644@kib.kiev.ua> References: <201212241422.qBOEMrcF021632@svn.freebsd.org> <CAJ-VmokV-JL_xZ9otRXubKZ8KQKe7GgLuLU3UMij0HUD_KhCNw@mail.gmail.com> <50D8B533.8080507@mu.org> <20121225104422.GB53644@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--kJMkLA1uPhjFFA+D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 25, 2012 at 12:44:22PM +0200, Konstantin Belousov wrote: > On Mon, Dec 24, 2012 at 12:04:03PM -0800, Alfred Perlstein wrote: > > On 12/24/12 11:24 AM, Adrian Chadd wrote: > > > ... why'd we break the KBI in a stable branch? > > > > > I am not sure either. > >=20 > > I think a single VOP for nullfs (while ugly) would have sufficed. > No, it doesn't. >=20 > Even if it would be sufficient, having a switch right after the > vtable call is silly. But, ignoring the sillyness, having a single > VOP forces a filesystem, needed to override the single bit of behaviour, > to override all behaviours hidden from under the common VOP. Besides > the incovenience, it breaks the bypass. This is why I did not went > this route in the HEAD commit. >=20 > Making HEAD and stable diverge for the VOP table is unmaintainable. >=20 > At least one other change which cannot be covered by the VOP table > hacking is the struct vfsops new method. >=20 > Traditionally (my memory goes back to 6.x branch) we did not maintained > VFS KBI stability on the branches. Forgot to note, you completely ignored the VOP vnode locking protocol in your patch. --kJMkLA1uPhjFFA+D Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQ2Y3TAAoJEJDCuSvBvK1BvfUP/Rp2E+p82BtuyLbvSr3cyQ2t ICfwzPODtyhcnhbqkJPRL9zLfxBwSydeudrWdqXvcAXg1YOCHMN4ec3kOeiYkJ23 yxgITuev2qNWB1uX6YCX3SFpEYxOC7/hcnJf36dlkZ5UzgG5uU/Q80EBf3dAbYqj hSqrgx689ueg6xFMFXXL0n3Tn8rzmsIuHK1aB6Z3aiK6wHhkiebJKns6EeK/4DSV E5CPoFSYjx2oEKCV3P4aprzcWyA3Vkhs6nHYSqcEzAaZwstArbO1vGO2cJPQijV6 54XcEPptNG+1WuJWf3I0G4dnp/l9UvMRs5cs8Ro7G7K+VK8UVlw0OvSGmKCP6ASb GMBKiSzKejxeGRRWhlgzM81u05co+NlZb9BsE/g/j3wKCLqNQeOsLirNxmsHGz7E np7l19hxDWI0k/CdN8QgBPD1A6qOdnJo/SPXRgtjOIzhsd/4WyAbuKogjY1/LuHj m5QX6jftSxRAJHJ+uUy5iNe49SoOo0Rj/Tu72vyCz2jTeobCE4XrurZ91WKhJ4YG uxyu2X2qqgZd2jL66krhJ5iT41BctzFuwfQLp0CevzIvcrzX5jXzmpaTtIYqnWBG ciR3v+HoobMV6zSQF3fbdT0yAZke6Zf9+1y0F/SP7i8yjJoKDQh8Ou6MweHbzvzh EGQojKIByGl0DkcgFuoP =0MQN -----END PGP SIGNATURE----- --kJMkLA1uPhjFFA+D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121225112820.GC53644>