Date: Sat, 14 Apr 2007 18:17:30 +0400 From: Stanislav Sedov <stas@FreeBSD.org> To: "Simon L. Nielsen" <simon@FreeBSD.org> Cc: cvs-src@FreeBSD.org, pav@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/contrib/top top.X top.c top.h src/usr.bin/top machine.c Message-ID: <20070414181730.eca262c0.stas@FreeBSD.org> In-Reply-To: <20070414124654.GB1687@zaphod.nitro.dk> References: <200704141016.l3EAGqIs023798@repoman.freebsd.org> <1176546388.54822.11.camel@ikaros.oook.cz> <1176546959.54822.14.camel@ikaros.oook.cz> <20070414154246.89ad2946.stas@FreeBSD.org> <20070414124654.GB1687@zaphod.nitro.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Sat__14_Apr_2007_18_17_30_+0400_JQ6psQbLV46yZVHJ Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: 7bit On Sat, 14 Apr 2007 14:46:55 +0200 "Simon L. Nielsen" <simon@FreeBSD.org> mentioned: > On 2007.04.14 15:42:46 +0400, Stanislav Sedov wrote: > > On Sat, 14 Apr 2007 12:35:59 +0200 > > Pav Lucistnik <pav@FreeBSD.org> mentioned: > > > > > > Also, is the width cut-off technical problem, or is it fixable? > > > See http://people.freebsd.org/~pav/top.png for what I mean. > > > > > > > Well, they allocate a static buffer of 128 byte lenght, so the result > > doesn't fit into it. Also, there's buffer overrun, since sprintf is > > used, not snprintf. > > So, if a user sets a very long proctitle now and some other user runs > top with the new feature the buffer will overflow? > Well, not quite right. If you screen is wider then 128 symbols, there could be an overflow, since the row buffer is 128 bytes length. I have not touched any limits, just replaced the string it displays. So there can be overflow with patch or without it, if both the command name and screen width is wider then 128. Well, anyway i'm going to fix that right now. -- Stanislav Sedov ST4096-RIPE --Signature=_Sat__14_Apr_2007_18_17_30_+0400_JQ6psQbLV46yZVHJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGIOJ6K/VZk+smlYERAg9EAJ4+T4qRlGvcUVv8352AzyzSKXdwXACfcUUY baXyjthbdINms/fgeIuCjD4= =+3/J -----END PGP SIGNATURE----- --Signature=_Sat__14_Apr_2007_18_17_30_+0400_JQ6psQbLV46yZVHJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070414181730.eca262c0.stas>