Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Mar 2010 12:12:09 +0100 (CET)
From:      Alexander Best <alexbestms@wwu.de>
To:        Jaakko Heinonen <jh@FreeBSD.org>
Cc:        freebsd-hackers@FreeBSD.org, Poul-Henning Kamp <phk@phk.freebsd.dk>, Bruce Evans <brde@optusnet.com.au>
Subject:   Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)
Message-ID:  <permail-20100311111209f0889e8400002de2-a_best01@message-id.uni-muenster.de>
In-Reply-To: <20100311102911.GA2574@a91-153-117-195.elisa-laajakaista.fi>

next in thread | previous in thread | raw e-mail | index | archive | help
Jaakko Heinonen schrieb am 2010-03-11:
> On 2010-03-10, Alexander Best wrote:
> > could this panic have been triggered by the patch?

> It doesn't look like it's caused by the patch.

> > panic() at panic+0x15f
> > _mtx_lock_flags() at _mtx_lock_flags+0xc5
> > fdesc_allocvp() at fdesc_allocvp+0xbf
> > fdesc_lookup() at fdesc_lookup+0x15c

> > this was 100% reducible when doing `portsnap fetch` though i
> > changed a lot of
> > stuff in my kernel config and reverted a lot of src patches to
> > resolve the
> > issue so i'm not sure what exactly was causing it.

> The panic happened in fdescfs code. Did you have local patches
> related
> to fdescfs?

after reverting a few patches (including yours) i got rid of the problem. i
then re-applied your patch and noticed that (as you said) it wasn't causing
the panic.

i don't have any fdescfs specific patches in my src. i suspect however [1]
being responsible for the panic. after backing it out i got no more panics in
connection with `portsnap fetch`.

[1] http://www.mail-archive.com/freebsd-hackers@freebsd.org/msg70400.html

thanks for the help

oh...and btw.:

i'm not sure but i think i've asked this question once before in this thread:

in sys/kern/vfs_syscalls.c:kern_rmdirat() there's still local code to check
for "." and "/" after applying your patch. isn't this all being done by
calling namei() now?

cheers.
alex



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?permail-20100311111209f0889e8400002de2-a_best01>