Date: Sat, 8 Aug 2009 10:10:07 GMT From: "b. f." <bf1783@googlemail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/137559: [NEW PORT] graphics/mupdf: Lightweight PDF viewer and toolkit Message-ID: <200908081010.n78AA7Fk037536@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/137559; it has been noted by GNATS.
From: "b. f." <bf1783@googlemail.com>
To: bug-followup@FreeBSD.org, Martin Dieringer <martin.dieringer@gmx.de>
Cc:
Subject: Re: ports/137559: [NEW PORT] graphics/mupdf: Lightweight PDF viewer
and toolkit
Date: Sat, 8 Aug 2009 10:00:28 +0000
Oh, wow: I was just going to do this one. :) Two nits:
1) Please don't hardcode /usr/local in the makefiles. Instead use
${LOCALBASE}. We've been trying to remove errors like this lately.
2) Could you please rename the NOCJK OPTION to CJK, as with other
ports, and reverse the logic accordingly? The extra negative in
WITH(OUT)_NOCJK is more confusing than WITH(OUT)_CJK.
Thanks.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908081010.n78AA7Fk037536>