Date: Wed, 13 Jan 2010 09:19:13 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: jhb@freebsd.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, dougb@freebsd.org, src-committers@freebsd.org, freebsd-arch@freebsd.org Subject: Re: INCLUDE_CONFIG_FILE in GENERIC Message-ID: <20100113.091913.1023414010414027273.imp@bsdimp.com> In-Reply-To: <201001130844.21241.jhb@freebsd.org> References: <20100110.210204.787670930858346133.imp@bsdimp.com> <4B4D109A.5060500@FreeBSD.org> <201001130844.21241.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <201001130844.21241.jhb@freebsd.org>
John Baldwin <jhb@freebsd.org> writes:
: On Tuesday 12 January 2010 7:15:22 pm Doug Barton wrote:
: > On 1/10/2010 8:02 PM, M. Warner Losh wrote:
: > > In message: <alpine.BSF.2.00.1001110348100.92627@serrsnyy.serrofq.bet>
: > > Doug Barton <dougb@FreeBSD.org> writes:
: > > : On Sun, 10 Jan 2010, Warner Losh wrote:
: > > :
: > > : > Author: imp
: > > : > Date: Sun Jan 10 17:44:22 2010
: > > : > New Revision: 202019
: > > : > URL: http://svn.freebsd.org/changeset/base/202019
: > > : >
: > > : > Log:
: > > : > Add INCLUDE_CONFIG_FILE in GENERIC on all non-embedded platforms.
: > > :
: > > : Thanks for doing this, however the comment about how to include the
: > > : whole file (including the comments) were not included. Do I need to do
: > > : this part of it myself? No problem if so, I just want to be sure to
: > > : get it done in time to MFC it before the freeze for 7.3-release.
: > >
: > > In general, we don't put big comments like that in the config files,
: > > preferring to leave them to NOTES. I was just following that
: > > convention...
: >
: > Understood, however given that there is plenty of room for confusion on
: > this point because the default is NOT to include the comments I think
: > that some explanation is justified. My original text was:
: >
: > # Store the plain version of the configuration file in the kernel itself.
: > # To store the entire file, including comments, put this in /etc/src.conf:
: > # CONFIGARGS= -C
: > # See config(8) for more details.
:
: Just put this in sys/conf/NOTES. Users already know to look in NOTES for
: further details about kernel options.
This exact comment already is in NOTES.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100113.091913.1023414010414027273.imp>