Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Mar 2013 08:59:42 +0100
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Jason Helfman <jgh@FreeBSD.org>, Beech Rintoul <beech@FreeBSD.org>
Subject:   Re: svn commit: r314117 - head/games/kye
Message-ID:  <20130314075942.GF53963@ithaqua.etoilebsd.net>
In-Reply-To: <20130314075330.GA94901@FreeBSD.org>
References:  <201303132159.r2DLx1QL092713@svn.freebsd.org> <20130314004930.GA16692@FreeBSD.org> <20130314070455.GA42406@hatter> <20130314075330.GA94901@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--DO5DiztRLs659m5i
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 14, 2013 at 07:53:30AM +0000, Alexey Dokuchaev wrote:
> On Thu, Mar 14, 2013 at 12:04:55AM -0700, Jason Helfman wrote:
> > On Thu, Mar 14, 2013 at 12:49:30AM +0000, Alexey Dokuchaev thus spake:
> > >>@@ -27,13 +27,12 @@ USE_PYTHON=3D	yes
> > >> USE_PYDISTUTILS=3D	yes
> > >> NO_BUILD=3D	yes
> > >>
> > >>-PORTDATA=3D	*
> > >> PORTDOCS=3D	NEWS README
> > >		^^^^^^^^^^^
> > >>+%%PORTDOCS%%%%DOCSDIR%%/NEWS
> > >>+%%PORTDOCS%%%%DOCSDIR%%/README
> > >
> > >Shouldn't it break the tinderbuild?
> >=20
> > This should not break tinderbuild
>=20
> What makes you think so?  I think that tindy will complain about nonexist=
ent
> files upon package deletion.
>=20
> > as this is a PLIST_SUB, and it will translate to:
> >=20
> > share/doc/kye/NEWS
> > share/doc/kye/README
>=20
> Correct.  That means, it now duplicates PORTDOCS set in the Makefile.
>=20
> ./danfe

and pkgng will warn (error iirc in DEVELOPER_MODE) about duplicated plist
entries.

regards,
Bapt

--DO5DiztRLs659m5i
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlFBg24ACgkQ8kTtMUmk6Ex4XACfcxKi3BaJy8Rih1WmjOtjYFLQ
omoAoKoTa+9czdfby5/ebgdbhk46c9ZU
=BD7h
-----END PGP SIGNATURE-----

--DO5DiztRLs659m5i--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130314075942.GF53963>