Date: Sun, 7 Mar 2004 02:40:13 -0800 (PST) From: "Cyrille Lefevre" <cyrille.lefevre@laposte.net> To: qa@FreeBSD.org Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time Message-ID: <200403071040.i27AeDoB029153@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/27483; it has been noted by GNATS.
From: "Cyrille Lefevre" <cyrille.lefevre@laposte.net>
To: "Peter Pentchev" <roam@ringlet.net>
Cc: <bug-followup@FreeBSD.org>, <freebsd-qa@FreeBSD.org>
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Sat, 6 Mar 2004 02:29:47 +0100
> On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote:
> > cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CET
2004)
> > anyone to commit this PR ?
> > thanks in advance.
> >
> [snip]
> > /* Begin user dialog at outer menu */
> > dialog_clear();
> > + if (getpid() == 1)
> > + dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max,
FALSE);
> > while (1) {
>
> Just a minor comment: shouldn't RunningAsInit be used here instead of
> a getpid() invocation? :)
maybe, don't know in fact ?
Cyrille Lefevre.
--
home: mailto:cyrille.lefevre@laposte.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200403071040.i27AeDoB029153>