Date: Wed, 22 Jun 2011 09:23:21 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Chris Rees <crees@freebsd.org> Cc: ports@freebsd.org, "Ilya A. Arkhipov" <micro@heavennet.ru>, kwm@freebsd.org Subject: portlint(1) knobs order: let's make things more logical Message-ID: <20110622092321.GA41257@FreeBSD.org> In-Reply-To: <BANLkTi=s6zYOJJv6%2Bkk%2Bttd7jadmTuaT6w@mail.gmail.com> References: <20110621214013.6cc4760e@heavennet.ru> <20110622020048.GA83940@FreeBSD.org> <BANLkTi=En%2B7nJgEmKCmBEQMwiV0nbcPhEg@mail.gmail.com> <20110622064224.GB94185@FreeBSD.org> <BANLkTi=s6zYOJJv6%2Bkk%2Bttd7jadmTuaT6w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Subject changed to reflect new course of the discussion ]
On Wed, Jun 22, 2011 at 09:56:55AM +0100, Chris Rees wrote:
> COMMENT
>
> LICENSE
>
> So license in a separate block; you can have several license lines
> making the MAINTAINER/COMMENT block unnecessarily large.
Agree here; space looks nice and natural.
> Not too sure about keeping _DEPENDS with USE; there're additional
> variables often set with USE, perhaps a block for _DEPENDS and then
> USE etc underneath? (could follow with USERS/GROUPS).
Yes, _DEPENDS first and USE_ below. Of course, for complicated ports both
of them can be set downwards the Makefile depending on various conditions.
> LIB_DEPENDS=
>
> BUILD_DEPENDS=
>
> RUN_DEPENDS=
These three are normally not separated by extra blank line. Also, I think
it makes more sense to list BUILD_DEPENDS first (think this: first come,
first go during the build (well, they normally stay, but can be purged after
build finishes). LIB_DEPENDS come second (required for both build and
runtime), RUN_DEPENDS should be last.
Here I once again want to mention that recommended way (per PH)
BUILD_DEPENDS= ...
RUN_DEPENDS:= ${BUILD_DEPENDS)
is better that what people sometimes use to avoid dependency pollution bug:
RUN_DEPENDS= ...
BUILD_DEPENDS= RUN_DEPENDS
As the latter is unnatural (we build stuff before we run it).
> USE_FOO
> FOO_ARGS
> USE_BAR
>
> USERS
> GROUPS
This is correct.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110622092321.GA41257>