Date: Sat, 04 Aug 2018 22:26:28 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 230362] net/csocks: Update to 1.7 Message-ID: <bug-230362-7788-jrHWa1tdRJ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230362-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-230362-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230362 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org --- Comment #5 from Tobias Kortkamp <tobik@freebsd.org> --- Comment on attachment 195859 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D195859 Update +USES=3D compiler:gcc-c++11-lib Does it not build with Clang anymore? Why does it require GCC now? Forcing GCC usage in a port should be a last resort. - ${INSTALL_LIB} ${WRKDIR}/src/libcsocks.so.1 ${STAGEDIR}${PREFIX}/lib - ${LN} -s libcsocks.so.1 ${STAGEDIR}${PREFIX}/lib/libcsocks.so + ${INSTALL_LIB} ${WRKDIR}/src/libcsocks.so.1 ${STAGEDIR}${PREFIX}/lib/libcsocks.so.1 + ${INSTALL_LIB} ${WRKDIR}/src/libcsocks.so.1 ${STAGEDIR}${PREFIX}/lib/libcsocks.so This is a bogus change. You're now installing libcsocks.so.1 twice (so the package will take twice the space). libcsocks.so should be a symli= nk. Please revert this. --- net/csocks/files/patch-csocks.c (nonexistent) +++ net/csocks/files/patch-csocks.c (working copy) net/csocks/files/patch-csocks.c looks fishy. Why is it needed and why does it remove a bunch of NULL checks? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230362-7788-jrHWa1tdRJ>