Date: Mon, 7 Dec 2015 12:22:35 +0100 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= <trasz@FreeBSD.org> To: Steven Hartland <smh@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291911 - head/sys/dev/iscsi Message-ID: <20151207112235.GA12517@brick.home> In-Reply-To: <201512070256.tB72u8C6057988@repo.freebsd.org> References: <201512070256.tB72u8C6057988@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1207T0256, Steven Hartland wrote: > Author: smh > Date: Mon Dec 7 02:56:08 2015 > New Revision: 291911 > URL: https://svnweb.freebsd.org/changeset/base/291911 > > Log: > Fix panic on shutdown due to iscsi event priority > > iscsi's shutdown_pre_sync prio was SHUTDOWN_PRI_FIRST which caused it to > run before other high priority handlers such as filesystems e.g. ZFS. > > This meant the iscsi sessions where removed before the ZFS geom consumer > was closed, resulting in a panic from g_access calls on debug kernels > due to negative acr. > > Instead use the same as the old iscsi_initiator SHUTDOWN_PRI_DEFAULT-1 > which allows it to run before dashutdown etc but after filesystems. I think this might be backwards. Have you tested the following scenario: 1. Establish the iSCSI session 2. Mount the LUN somewhere 3. Make the target not reachable (eg ifconfig down), so that the initiator tries to reconnect 4. Try to shutdown? Basically, the point of this code is to disable reconnects when there won't be any iscsid(8) instance to handle them. The iscsi_shutdown() isn't supposed to remove working iSCSI sessions.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151207112235.GA12517>