Date: Wed, 10 May 2000 01:49:51 +0900 (JST) From: sanpei@sanpei.org (MIHIRA Yoshiro) To: n_hibma@calcaphon.com Cc: wesleymorgan@home.com, current@FreeBSD.ORG, sanpei@sanpei.org, jlemon@FreeBSD.org Subject: Re: LINT broken. (in_cksum changes) Message-ID: <200005091649.BAA10966@lavender.yy.cs.keio.ac.jp> In-Reply-To: Your message of "Tue, 9 May 2000 19:20:20 JST". <Pine.BSF.4.20.0005091119470.61785-100000@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
>> > On Sun, 7 May 2000, Nick Hibma wrote: >> > >> > > >> > > Is it only me that ever compiles LINT? The checksum changes went in a >> > > few days ago. >> > > >> > > Please, people, when you move code around or change a function that is >> > > used in more than a fixed set of files, compile LINT. If unsure, compile >> > > LINT. It's an extra five minutes, but well worth it. >> > > >> > > linking kernel >> > > fil.o: In function `fr_tcpsum': >> > > fil.o(.text+0xf47): undefined reference to `in_cksum' >> > > ip_fil.o: In function `send_reset': >> > > ip_fil.o(.text+0xd7d): undefined reference to `in_cksum' >> > > ip_fil.o: In function `ipfr_fastroute': >> > > ip_fil.o(.text+0x10f1): undefined reference to `in_cksum' >> > > ip_fil.o(.text+0x1316): undefined reference to `in_cksum' >> > > ip_fil.o(.text+0x1380): undefined reference to `in_cksum' >> > > ip_mroute.o(.text+0x19d6): more undefined references to `in_cksum' >> > > follow I had same problem with below options: options IPFILTER #ipfilter support options IPFILTER_LOG #ipfilter logging options IPSEC #IP security I think this problem related to jlemon-san's commit. >jlemon 2000/05/06 11:18:33 PDT > > Modified files: > sys/alpha/alpha in_cksum.c > sys/alpha/include in_cksum.h > sys/i386/i386 in_cksum.c > sys/i386/include in_cksum.h > Log: > Make in_cksum() a macro call to in_cksum_skip(), since it provides the > same functionality. Sharing code should help cache issues. > > Remove in_cksum_partial, since its not being used, and we now have > a way to compute partial checksums on mbuf chains. in_cksum function was removed and change into macro. --- in sys/i386/include/in_cksum.h #define in_cksum(m, len) in_cksum_skip(m, len, 0) --- It needs to some code to compile with those options... MIHIRA Yoshiro To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200005091649.BAA10966>