Date: Fri, 17 Dec 2004 11:32:40 -0500 From: Ken Smith <kensmith@cse.Buffalo.EDU> To: Darren Reed <darrenr@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet ip_nat.c Message-ID: <20041217163240.GD20065@electra.cse.Buffalo.EDU> In-Reply-To: <200412171559.iBHFxGm1066750@repoman.freebsd.org> References: <200412171559.iBHFxGm1066750@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--7JfCtLOvnd9MIVvH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Dec 17, 2004 at 03:59:16PM +0000, Darren Reed wrote:
> darrenr 2004-12-17 15:59:16 UTC
>=20
> FreeBSD src repository
>=20
> Modified files: (Branch: RELENG_5)
> sys/contrib/ipfilter/netinet ip_nat.c=20
> Log:
> Move two variables that are unused if LARGE_NAT is defined inside an #i=
fdef
> to keep them out of harms way when compiling.
> =20
> PR: 72783
> =20
> Revision Changes Path
> 1.34.2.2 +5 -2 src/sys/contrib/ipfilter/netinet/ip_nat.c
[ Not meaning to explicitly pick on Darren - just using this particular
commit to remind everyone. Several people have done this lately. ]
We understand that some of you do extensive testing before committing
even to HEAD, and we appreciate that. But even for those cases re@
would appreciate it if things could simmer in HEAD for at least a
couple of days before being MFCed. Even the best of us have been
caught off guard with things that didn't show up in our testing but
once it got out into a larger testbed a nit or two showed up. With
RELENG_5 now considered -stable unless there is some sort of emergency
please follow the 3-day or so simmer-in-HEAD rule of thumb.
Thanks.
--=20
Ken Smith
- From there to here, from here to | kensmith@cse.buffalo.edu
there, funny things are everywhere. |
- Theodore Geisel |
--7JfCtLOvnd9MIVvH
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (SunOS)
iD8DBQFBwwol/G14VSmup/YRAoAcAJ9qAKtkabsfbK8w+OvPpMiOvUqwYQCeOgho
UURc2GvtjqRZCkGCgzf8E/4=
=0tI2
-----END PGP SIGNATURE-----
--7JfCtLOvnd9MIVvH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041217163240.GD20065>