Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 May 2005 12:51:39 +0200 (CEST)
From:      Harti Brandt <hartmut.brandt@dlr.de>
To:        Max Okumoto <okumoto@ucsd.edu>
Cc:        cvs-src@FreeBSD.org
Subject:   Re: cvs commit: src/usr.bin/make job.c job.h main.c
Message-ID:  <20050524124930.F50725@beagle.kn.op.dlr.de>
In-Reply-To: <4292FE79.70205@ucsd.edu>
References:  <200505240914.j4O9EkrC043155@repoman.freebsd.org> <4292FE79.70205@ucsd.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 24 May 2005, Max Okumoto wrote:

MO>Hartmut Brandt wrote:
MO>> harti       2005-05-24 09:14:46 UTC
MO>> 
MO>>   FreeBSD src repository
MO>> 
MO>>   Modified files:
MO>>     usr.bin/make         job.c job.h main.c   Log:
MO>>   Before doing any parsing parse the builtin shell specifications and
MO>>   set the current shell to DEFSHELL. Put all these specifications into
MO>>   a list. Add user specified new shells to this list. If the user
MO>>   just selects one of the already know shells just pick the right one
MO>>   off the list. This let's one do something like:
MO>>     # Full specification of the user's shell. This also selects the shell.
MO>>   .SHELL: name=myshell path=/somewhere/foo echo=loud ...
MO>>     FOO != bar              # use myshell here
MO>>     .SHELL: name=sh
MO>>     BAR != baz              # use /bin/sh here
MO>>     .SHELL: name=myshell    # no need for full spec here.
MO>>     # continue to use the user's special shell.
MO>>     Revision  Changes    Path
MO>>   1.116     +195 -178  src/usr.bin/make/job.c
MO>>   1.44      +2 -0      src/usr.bin/make/job.h
MO>>   1.152     +7 -0      src/usr.bin/make/main.c
MO>> _______________________________________________
MO>> cvs-src@freebsd.org mailing list
MO>> http://lists.freebsd.org/mailman/listinfo/cvs-src
MO>> To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org"
MO>> 
MO>
MO>Harti,
MO>
MO>Please make sure to attribute patches to DragonFly when you take
MO>things from their CVS.  Most of the work is in this patch is yours
MO>but there are some changes that appear like they came from the DragonFly
MO>tree.

Can you point me at what you think came from DragonFly? If you talk about 
the ArgArray stuff, then there is the correct attribution in that commit. 
The stuff here was fully done by me. I didn't have a look at DragonFly's 
make since I got the ArgArray stuff.

harti



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050524124930.F50725>