Date: Sat, 9 Nov 1996 22:16:33 GMT From: Mark Valentine <mark@linus.demon.co.uk> To: FreeBSD-gnats-submit@freebsd.org Subject: bin/1986: error in lpr(1) argument handling [with fix] Message-ID: <199611092216.WAA18201@janai.thuvia.org> Resent-Message-ID: <199611092220.OAA24688@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 1986 >Category: bin >Synopsis: error in lpr(1) argument handling [with fix] >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Nov 9 14:20:01 PST 1996 >Last-Modified: >Originator: Mark Valentine >Organization: >Release: FreeBSD 3.0-CURRENT i386 >Environment: n/a >Description: There's an off-by-one error in lpr(1)'s default jobname code. >How-To-Repeat: ``lpr /etc/motd'' with banner page enabled; job name will be random garbage. >Fix: [first hunk is irrelevant cosmetic adjustment] --- lpr.c.ctm Fri Nov 8 04:12:51 1996 +++ lpr.c Sat Nov 9 22:01:56 1996 @@ -76,7 +76,7 @@ static char *cfname; /* daemon control files, linked from tf's */ static char *class = host; /* class title on header page */ -static char *dfname; /* data files */ +static char *dfname; /* data files */ static char *fonts[4]; /* troff font names */ static char format = 'f'; /* format char for printing files */ static int hdr = 1; /* print header or not (default is yes) */ @@ -285,10 +285,10 @@ card('P', person); if (hdr) { if (jobname == NULL) { - if (argc == 1) + if (argc == 0) jobname = "stdin"; else - jobname = (arg = rindex(argv[1], '/')) ? arg+1 : argv[1]; + jobname = (arg = rindex(argv[0], '/')) ? arg+1 : argv[0]; } card('J', jobname); card('C', class); >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199611092216.WAA18201>