Date: Mon, 17 May 2010 14:03:34 -0700 From: Randall Stewart <rrs@lakerest.net> To: Neel Natu <neelnatu@gmail.com> Cc: freebsd-mips@freebsd.org Subject: Re: Minor fixup for the MIPS SMP platform code. Message-ID: <895F98F0-ED84-4F68-898B-F88BE014633F@lakerest.net> In-Reply-To: <AANLkTin1CmrTmuwChVnwBaSRsnQO8mcwE5P9fXBtPTvp@mail.gmail.com> References: <AANLkTikjF2SUa5GomVRtus176hjKyUyPAeDF-p1kwCcO@mail.gmail.com> <AANLkTin1CmrTmuwChVnwBaSRsnQO8mcwE5P9fXBtPTvp@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Neel: I will make sure I get this fixed when I commit it tonight.. Thanks for your comments ;-) R On May 17, 2010, at 8:38 AM, Neel Natu wrote: > Hi JC, > > Your patch looks good. Thanks for cleaning up the platform-specific > code from mp_machdep.c. > > There are a couple of style things you might want to take care of: > > 1. In hwfunc.h there is an extra space after the '*' in the > declaration of platform_smp_topo() > > 2. In platform_smp_topo() for XLR: > - Values in return statements should be enclosed in parantheses. > - space around binary operator '/' > > best > Neel > > On Mon, May 17, 2010 at 7:33 AM, C. Jayachandran > <c.jayachandran@gmail.com> wrote: >> The attached patch (also at >> http://sites.google.com/site/cjayachandran/files) has two changes: >> - moves the intr masking code to platform_init_ap, so that we can >> avoid the >> #ifdef for XLR >> - adds a platform_smp_topo() function so that platforms can define >> their >> topology >> >> I've also attempted to fixup sys/mips/sibyte to reflect these >> changes, but >> it might need further work. >> sys/mips/cavium also might need similar changes for SMP. >> >> Please review and apply if the changes are okay. >> >> Thanks, >> JC. >> >> > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?895F98F0-ED84-4F68-898B-F88BE014633F>