Date: Wed, 08 Nov 2000 18:35:20 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Maksim Yevmenkin <m_evmenkin@yahoo.com> Cc: freebsd-hackers@FreeBSD.ORG, freebsd-current@FreeBSD.ORG Subject: Re: [PATCH] Please review and commit (Re: if_tap and devfs) Message-ID: <4778.973704920@critter> In-Reply-To: Your message of "Wed, 08 Nov 2000 09:31:00 PST." <20001108173100.11468.qmail@web122.yahoomail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I just glanced at it and see no major mistakes. Sorry I don't have time for a real review. Poul-Henning In message <20001108173100.11468.qmail@web122.yahoomail.com>, Maksim Yevmenkin writes: >--0-783368690-973704660=:11219 >Content-Type: text/plain; charset=us-ascii >Content-Disposition: inline > >Hello All, > >anyone wants to review and commit the following patch. > >thanks, >emax > > >__________________________________________________ >Do You Yahoo!? >Thousands of Stores. Millions of Products. All in one Place. >http://shopping.yahoo.com/ >--0-783368690-973704660=:11219 >Content-Type: application/x-unknown; name="if_tap.c.diff" >Content-Transfer-Encoding: base64 >Content-Description: if_tap.c.diff >Content-Disposition: attachment; filename="if_tap.c.diff" > >KioqIGlmX3RhcC5jLm9yaWcJTW9uIE5vdiAgNiAwOToyNDowOCAyMDAwCi0t >LSBpZl90YXAuYwlNb24gTm92ICA2IDEwOjI2OjM1IDIwMDAKKioqKioqKioq >KioqKioqCioqKiA3OSw4NCAqKioqCi0tLSA3OSw4NSAtLS0tCiAgc3RhdGlj >IGludCAJCXRhcG1vZGV2ZW50CV9fUCgobW9kdWxlX3QsIGludCwgdm9pZCAq >KSk7CiAgCiAgLyogZGV2aWNlICovCisgc3RhdGljIHZvaWQJCXRhcGNsb25l >CV9fUCgodm9pZCAqLCBjaGFyICosIGludCwgZGV2X3QgKikpOwogIHN0YXRp >YyB2b2lkCQl0YXBjcmVhdGUJX19QKChkZXZfdCkpOwogIAogIC8qIG5ldHdv >cmsgaW50ZXJmYWNlICovCioqKioqKioqKioqKioqKgoqKiogMTMxLDE1NyAq >KioqCiAgCWludAkJIHR5cGU7CiAgCXZvaWQJCSpkYXRhOwogIHsKISAJc3Rh >dGljIGludAkJIGF0dGFjaGVkID0gMDsKISAJc3RydWN0IGlmbmV0CQkqaWZw >ID0gTlVMTDsKISAJaW50CQkJIHVuaXQsIHM7CiAgCiAgCXN3aXRjaCAodHlw >ZSkgewogIAljYXNlIE1PRF9MT0FEOgogIAkJaWYgKGF0dGFjaGVkKQogIAkJ >CXJldHVybiAoRUVYSVNUKTsKICAKICAJCWNkZXZzd19hZGQoJnRhcF9jZGV2 >c3cpOwogIAkJYXR0YWNoZWQgPSAxOwogIAlicmVhazsKICAKISAJY2FzZSBN >T0RfVU5MT0FEOgogIAkJaWYgKHRhcHJlZmNudCA+IDApCiAgCQkJcmV0dXJu >IChFQlVTWSk7CiAgCiAgCQljZGV2c3dfcmVtb3ZlKCZ0YXBfY2RldnN3KTsK >ICAKICAJCXVuaXQgPSAwOwogIAkJd2hpbGUgKHVuaXQgPD0gdGFwbGFzdHVu >aXQpIHsKICAJCQlzID0gc3BsaW1wKCk7CiAgCQkJVEFJTFFfRk9SRUFDSChp >ZnAsICZpZm5ldCwgaWZfbGluaykKICAJCQkJaWYgKChzdHJjbXAoaWZwLT5p >Zl9uYW1lLCBUQVApID09IDApIHx8Ci0tLSAxMzIsMTY0IC0tLS0KICAJaW50 >CQkgdHlwZTsKICAJdm9pZAkJKmRhdGE7CiAgewohIAlzdGF0aWMgaW50CQlh >dHRhY2hlZCA9IDA7CiEgCXN0YXRpYyBldmVudGhhbmRsZXJfdGFnCWVoX3Rh >ZyA9IE5VTEw7CiAgCiAgCXN3aXRjaCAodHlwZSkgewogIAljYXNlIE1PRF9M >T0FEOgogIAkJaWYgKGF0dGFjaGVkKQogIAkJCXJldHVybiAoRUVYSVNUKTsK >ICAKKyAJCWVoX3RhZyA9IEVWRU5USEFORExFUl9SRUdJU1RFUihkZXZfY2xv >bmUsIHRhcGNsb25lLCAwLCAxMDAwKTsKICAJCWNkZXZzd19hZGQoJnRhcF9j >ZGV2c3cpOwogIAkJYXR0YWNoZWQgPSAxOwogIAlicmVhazsKICAKISAJY2Fz >ZSBNT0RfVU5MT0FEOiB7CiEgCQlpbnQJdW5pdDsKISAKICAJCWlmICh0YXBy >ZWZjbnQgPiAwKQogIAkJCXJldHVybiAoRUJVU1kpOwogIAorIAkJRVZFTlRI >QU5ETEVSX0RFUkVHSVNURVIoZGV2X2Nsb25lLCBlaF90YWcpOwogIAkJY2Rl >dnN3X3JlbW92ZSgmdGFwX2NkZXZzdyk7CiAgCiAgCQl1bml0ID0gMDsKICAJ >CXdoaWxlICh1bml0IDw9IHRhcGxhc3R1bml0KSB7CisgCQkJaW50CQkgczsK >KyAJCQlzdHJ1Y3QgaWZuZXQJKmlmcCA9IE5VTEw7CisgCiAgCQkJcyA9IHNw >bGltcCgpOwogIAkJCVRBSUxRX0ZPUkVBQ0goaWZwLCAmaWZuZXQsIGlmX2xp >bmspCiAgCQkJCWlmICgoc3RyY21wKGlmcC0+aWZfbmFtZSwgVEFQKSA9PSAw >KSB8fAoqKioqKioqKioqKioqKioKKioqIDE3OSwxODUgKioqKgogIAkJfQog >IAogIAkJYXR0YWNoZWQgPSAwOwohIAlicmVhazsKICAKICAJZGVmYXVsdDoK >ICAJCXJldHVybiAoRU9QTk9UU1VQUCk7Ci0tLSAxODYsMTkyIC0tLS0KICAJ >CX0KICAKICAJCWF0dGFjaGVkID0gMDsKISAJfSBicmVhazsKICAKICAJZGVm >YXVsdDoKICAJCXJldHVybiAoRU9QTk9UU1VQUCk7CioqKioqKioqKioqKioq >KgoqKiogMTg3LDE5MiAqKioqCi0tLSAxOTQsMjM0IC0tLS0KICAKICAJcmV0 >dXJuICgwKTsKICB9IC8qIHRhcG1vZGV2ZW50ICovCisgCisgCisgLyoKKyAg >KiBERVZGUyBoYW5kbGVyCisgICoKKyAgKiBXZSBuZWVkIHRvIHN1cHBvcnQg >dHdvIGtpbmQgb2YgZGV2aWNlcyAtIHRhcCBhbmQgdm1uZXQKKyAgKi8KKyBz >dGF0aWMgdm9pZAorIHRhcGNsb25lKGFyZywgbmFtZSwgbmFtZWxlbiwgZGV2 >KQorIAl2b2lkCSphcmc7CisgCWNoYXIJKm5hbWU7CisgCWludAkgbmFtZWxl >bjsKKyAJZGV2X3QJKmRldjsKKyB7CisgCWludAkgdW5pdCwgbWlub3I7Cisg >CWNoYXIJKmRldmljZV9uYW1lID0gTlVMTDsKKyAKKyAJaWYgKCpkZXYgIT0g >Tk9ERVYpCisgCQlyZXR1cm47CisgCisgCWRldmljZV9uYW1lID0gVEFQOwor >IAlpZiAoZGV2X3N0ZGNsb25lKG5hbWUsIE5VTEwsIGRldmljZV9uYW1lLCAm >dW5pdCkgIT0gMSkgeworIAkJZGV2aWNlX25hbWUgPSBWTU5FVDsKKyAKKyAJ >CWlmIChkZXZfc3RkY2xvbmUobmFtZSwgTlVMTCwgZGV2aWNlX25hbWUsICZ1 >bml0KSAhPSAxKQorIAkJCXJldHVybjsKKyAKKyAJCW1pbm9yID0gKHVuaXQg >fCAgVk1ORVRfREVWX01BU0spOworIAl9CisgCWVsc2UKKyAJCW1pbm9yID0g >dW5pdDsKKyAKKyAJKmRldiA9IG1ha2VfZGV2KCZ0YXBfY2RldnN3LCBtaW5v >ciwgVUlEX1JPT1QsIEdJRF9XSEVFTCwgMDYwMCwgIiVzJWQiLAorIAkJCWRl >dmljZV9uYW1lLCB1bml0KTsKKyB9IC8qIHRhcGNsb25lICovCiAgCiAgCiAg >LyoK > >--0-783368690-973704660=:11219-- > > >To Unsubscribe: send mail to majordomo@FreeBSD.org >with "unsubscribe freebsd-current" in the body of the message > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4778.973704920>