Date: Mon, 18 Jan 2016 16:18:39 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Raphael Kubo da Costa <rakuco@FreeBSD.org> Cc: gnome@FreeBSD.org, perl@FreeBSD.org Subject: Re: libperl stage-qa check and libraries that do not link against libperl.so Message-ID: <1927902E41BBF231A0EF6A54@ogg.in.absolight.net> In-Reply-To: <8637tvyzpe.fsf@FreeBSD.org> References: <86d1t0nu6x.fsf@FreeBSD.org> <83298B9CC954C7F5642168D0@atuin.in.mat.cc> <868u3nonxn.fsf@FreeBSD.org> <880733D886684E0C0D43E7D8@atuin.in.mat.cc> <8637tvyzpe.fsf@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========228AEED0E78C520F8C8A========== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline +--On 18 janvier 2016 08:00:29 -0200 Raphael Kubo da Costa <rakuco@FreeBSD.org> wrote: | Mathieu Arnold <mat@FreeBSD.org> writes: | |> +--On 17 janvier 2016 23:12:36 +0100 Raphael Kubo da Costa |> <rakuco@FreeBSD.org> wrote: |> |> For these, if the non-linking is intentional, and not needed, |> |> ignore the ***WARNING***. |> | |> | Right. If linking against libperl.so and not linking against it are |> | both fine, does it still make sense to have that stage-qa check? |> |> There is a stage-qa check because if you link against libperl.so, you |> MUST have rpath set to the path of libperl.so, it happens if the port is |> doing what Perl should be doing and getting it wrong. Also, sometime, |> you don't link with libperl.so, and it's a mistake, and it should be. |> |> There are a few cases where it's not needed, but when I added the qa |> check when I changed libperl.so to be versionned, out of all the ports |> that install .so in PERL_ARCH, there were, say, 3 or 4 that had a .so |> that did not need to be linked with libperl.so. | | How about making the "not linked with libperl.so.x.y" warning non-fatal | then? Right now I cannot just ignore it as suggested because it makes | the script exit with a non-zero error code. I just had a look at the commit, and the qa script is right. The author is wrong, the .so contains Perl code and must be linked with libperl.so. It must be linked with it so that when the major Perl version is changed (like 5.20 -> 5.22 that is happening soon(tm)) the link allows pkg to know that the package needs to be reinstalled so that it continues to work. | While here: there's a FIXME comment in this part that talks about | changing the linkage detection logic, but it does not specify what | should be changed. Do you have more information? I could try to fix both | issues and send a patch for review. I forgot about the FIXME. It works as intented right now, I'll have a look at it later. -- Mathieu Arnold --==========228AEED0E78C520F8C8A========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJWnQJPXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IzqsQAJ1pR0n4NhkP/v3dIUwDXWzU I1t0md7d3uoi4Utjo8EUXw/JVHUag3sKZorL7jkbA+83+5JTcKhVxmAdJ1DlNi58 V5aqTUmMRO6Ycym/iJD4xgMi+76ypv6xxY+1ZjQpsx1TWeH3JyQAUNHvRq+SyiNw SiDY56XdS5HMS+byVaJFu0JugvDPPuqXHNQ5LovGTCZ99g+kUenxceyE4v/nnB5w lWFJykWXKjbgykSm8vygV5itwW7PF2B3jjlDizInmzDeBA55jy5TR5IUnrM/RbDh 2Xjx0GP6AxGrOk7IrI13JMilPZejPCMWVLCalPHFkST9KlAS5+XgYlq7B0b4RuWb gDoplxe2dqDEdQGfs+yezk1BrdyE6meX81PYDZsex6daW6w+9ZXbLYN/FRG+RwOc xhiVcYLaYcSfFWztWh7UfUkuLe4PCUuFBeQtBE/67NaOz1KM3hRtALUDcY04Jx7o mE9FdCJrH09K0DkiiiTZ9+MQFGGolB+BUBFMZz3+3to5L1DJbdTEdTfXolvD0xGB PZoEc8o9WLLnS+H2ihDPHM9+4h8cEZt1THvkD8qUC6uucQWrQi+lJ3ICMpPWvaqi hh/LUxr5Q/bxPTD4KHmAq69XFjNU0yVD/2vGE55dCoDYNo04mFyln+XzmfkQfAxs tqqAprEMM2IKcycxjBz8 =eRDF -----END PGP SIGNATURE----- --==========228AEED0E78C520F8C8A==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1927902E41BBF231A0EF6A54>