Date: Tue, 04 Mar 2014 09:38:50 +0100 From: =?UTF-8?B?xYF1a2FzeiBXxIVzaWtvd3NraQ==?= <lukasz@wasikowski.net> To: Ruslan Makhmatkhanov <cvs-src@yandex.ru>, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/187240: sysutils/tcplist incompatible with sysutils/lsof Message-ID: <5315911A.2050403@wasikowski.net> In-Reply-To: <201403040810.s248A1HP029270@freefall.freebsd.org> References: <201403040810.s248A1HP029270@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
W dniu 2014-03-04 09:10, Ruslan Makhmatkhanov pisze:
> The following reply was made to PR ports/187240; it has been noted by GNATS.
>
> From: Ruslan Makhmatkhanov <cvs-src@yandex.ru>
> To: C Hutchinson <portmaster@bsdforge.com>
> Cc: bug-followup@FreeBSD.org
> Subject: Re: ports/187240: sysutils/tcplist incompatible with sysutils/lsof
> Date: Tue, 04 Mar 2014 12:00:15 +0400
>
> This is a multi-part message in MIME format.
> --------------060704030206060703030302
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
> Content-Transfer-Encoding: 7bit
>
> So, this is proper lsof commandline. It outputs like:
>
> uid x.x.x.x:10859->y.y.y.y:22
> uid x.x.x.x:16573->y.y.y.y:80
> uid x.x.x.x:19337->y.y.y.y:80
>
> and tcplist now fails with:
> select: Bad file descriptor
>
> Looks like the code needs to be updated to modern network stuff.
>
> --
> Regards,
> Ruslan
>
> T.O.S. Of Reality
>
>
> --------------060704030206060703030302
> Content-Type: text/x-patch;
> name="tcplist.diff"
> Content-Transfer-Encoding: 7bit
> Content-Disposition: attachment;
> filename="tcplist.diff"
>
> Index: files/patch-03
> ===================================================================
> --- files/patch-03 (revision 346995)
> +++ files/patch-03 (working copy)
> @@ -5,7 +5,7 @@
> #else /* !OLDLSOF */
> /* These use the current (as of 3.62W, at least) parameters for lsof */
> -#define LSOFCMD "lsof -nPsli TCP | awk '{print $3,$NF}' | sort | uniq"
> -+#define LSOFCMD "lsof -nPsli TCP | awk '{print $3,$(NF - 1)}' | sort | uniq"
> ++#define LSOFCMD "lsof -nPls -iTCP | awk '{print $3,$(NF - 1)}' | tail -n+2 | sort | uniq"
> #endif /* !OLDLSOF */
> #endif /* LSOFCMD */
Instead of using sort | uniq it's better to use sort -u - one process
spawn less.
--
best regards,
Lukasz Wasikowski
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5315911A.2050403>