Date: Wed, 24 Mar 1999 02:20:02 -0800 (PST) From: "Jukka A. Ukkonen" <jau@jau.tmt.tele.fi> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/10728: WCD driver does not recognize a recovered atapi/ide error Message-ID: <199903241020.CAA13796@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/10728; it has been noted by GNATS.
From: "Jukka A. Ukkonen" <jau@jau.tmt.tele.fi>
To: sheldonh@iafrica.com (Sheldon Hearn)
Cc:
Subject: Re: kern/10728: WCD driver does not recognize a recovered atapi/ide error
Date: Wed, 24 Mar 1999 12:07:46 +0200 (EET)
Quoting Sheldon Hearn:
>
> The problem you reported is unlikely to receive attention in the 2.2
> branch for which active development is over.
>
> Do you get the same results using 3.1-STABLE or 4.0-CURRENT?
>
> Ciao,
> Sheldon.
Actually I have not tested the wcd.c code for those versions,
because I have not had a chance to upgrade to 3.1 yet. I have
not even received my CD yet.
Anyhow I just had a quick look at the 3.1 code on nic.funet.fi
(a.k.a www.fi.freebsd.org), and it seems the wcd.c code has been
moved completely over to atapi-cd.c, but the strategy there still
seems to be exactly what caused fuzz in 2.2.8. The tests for the
result code in 3.1 atapi-cd.c are done like this
if (result.code) {
atapi_error(cdp->ata, cdp->unit, result);
return EIO;
}
This is exactly the same as in the old wcd.c in 2.2.8 (except the
name of the error function is not wcd_error) for which I changed
the if-condition to read
if (result.code
&& ((result.error & AER_SKEY) != AER_SK_RECOVERED_ERROR))
In general the logic in the new atapi-cd.c seems basically unchanged
from what it was in wcd.c in 2.2.8. So, I have every reason to
believe the same changes should still be applicable.
Cheers,
// jau
.--- ..- -.- -.- .- .- .-.-.- ..- -.- -.- --- -. . -.
/ Jukka A. Ukkonen, Internet Services R&D / Sonera Ltd.
/__ M.Sc. (sw-eng & cs) (Phone) +358-2040-63673
/ Internet: Jukka.Ukkonen@sonera.fi (Fax) +358-2040-64724
/ Internet: jau@iki.fi (Mobile) +358-400-606671
v Internet: ukkonen@nic.funet.fi (Home&Fax) +358-9-6215280
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199903241020.CAA13796>