Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Dec 1997 23:54:07 -0800
From:      David Greenman <dg@root.com>
To:        Julian Elischer <julian@whistle.com>
Cc:        Gary Palmer <gjp@erols.com>, current@freebsd.org
Subject:   Re: crash (in networking code?) 
Message-ID:  <199712250754.XAA17244@implode.root.com>
In-Reply-To: Your message of "Wed, 24 Dec 1997 23:44:54 PST." <Pine.BSF.3.95.971224234205.17456E-100000@current1.whistle.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
>>    The problem might be fixed with the attached diff. I have also committed
>> this in rev 1.37 of in_pcb.c.
>> 
>> -DG
>Is the aim of this change, to move the MALLOC out of the splnet()
>region?

   No. The purpose is to do the potentially blocking malloc first.

>I would have thought this was safe.  What is the failure mode? (I am not
>saying it's not a problem, just that I don't understand it..) 

   The cached PCB pointer (inp) becomes stale if malloc blocks.

-DG

David Greenman
Core-team/Principal Architect, The FreeBSD Project



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712250754.XAA17244>