Date: Mon, 29 Dec 2008 12:50:38 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Scott Long <scottl@samsco.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "mav@freebsd.org" <mav@freebsd.org>, "M. Warner Losh" <imp@bsdimp.com> Subject: Re: svn commit: r186182 - head/sys/dev/ata Message-ID: <20081229205038.GL20239@elvis.mu.org> In-Reply-To: <32523.1230450781@critter.freebsd.dk> References: <20081228053530.GF18389@elvis.mu.org> <32523.1230450781@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
* Poul-Henning Kamp <phk@phk.freebsd.dk> [081227 23:53] wrote: > In message <20081228053530.GF18389@elvis.mu.org>, Alfred Perlstein writes: > >* Scott Long <scottl@samsco.org> [081226 18:34] wrote: > > >> I prefer to do nothing. It's not unsafe or erroneous to access cfg > >> registers. But if some kind of message does get added, I insist that > >> it drop all pretenses and say, "you're too poor to run freebsd, come > >> back when you can afford better hardware.". :) > > > >Well that could be the result of a driver that has a "bug" that > >makes it access cfg space when it does not need to, as what seems > >to have just been fixed. > > How about adding a counter and a rate warning under INVARIANTS ? Yeah, again it's one of those things that I think I understand at a high level, but I don't have the hands-on skills to do it in a timely manner. I'll look into it if people keep tripping over this. thank you, -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081229205038.GL20239>