Date: Sat, 23 Jul 2016 13:59:29 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 211201] print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code : [Attachment 172889] Proposed patch (since 412348 revision) Message-ID: <bug-211201-6497-F1oJaIAy2A@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-211201-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-211201-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
lightside <lightside@gmx.com> has asked gnome@FreeBSD.org for maintainer-approval: Bug 211201: print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211201 Attachment 172889: Proposed patch (since 412348 revision) https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172889&action=3Dedit --- Comment #17 from lightside <lightside@gmx.com> --- Created attachment 172889 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172889&action= =3Dedit Proposed patch (since 412348 revision) (In reply to comment #16) > The file documents how to use (included) licenses but isn't an actual license. I included docs/LICENSE.TXT (as FREETYPE2) for informative purposes. It can= be removed for purist's purposes. Possible to create DOCS option with PORTDOCS=3Dreference CHANGES formats.txt LICENSE.TXT raster.txt (In reply to comment #16) > BOTH option may confuse users but can be eliminated via OPTIONS_GROUP at = the > cost of losing option helpers for the conditional. The usage of OPTIONS_RADIO is correct (List of radio-choice grouped options= : 0 or 1 among N). Do you think V38 and V40 are more easy to understand? In overall options th= is is correct and understandable: someone knows Infinality code, someone knows= new mininal code (a.k.a. ClearType), someone associates them with concrete vers= ions of TrueType interpreters (v35, v38, v40) as in source code. Moreover, "Compile both" is used in ftoption.h: http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/include/freety= pe/c onfig/ftoption.h?id=3DVER-2-6-5#n619 (In reply to comment #16) > # Note that though plus is allowed in a variable (and this license) name = it > # needs an extra space before following equals sign for them not to be pa= rsed > # as a single +=3D operator Yes, it works. Thanks. The new proposed patch attached, related to license changes.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211201-6497-F1oJaIAy2A>