Date: Mon, 18 Jan 2016 16:34:56 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Raphael Kubo da Costa <rakuco@FreeBSD.org> Cc: gnome@FreeBSD.org, perl@FreeBSD.org Subject: Re: libperl stage-qa check and libraries that do not link against libperl.so Message-ID: <C3873737817287E61167F372@ogg.in.absolight.net> In-Reply-To: <1927902E41BBF231A0EF6A54@ogg.in.absolight.net> References: <86d1t0nu6x.fsf@FreeBSD.org> <83298B9CC954C7F5642168D0@atuin.in.mat.cc> <868u3nonxn.fsf@FreeBSD.org> <880733D886684E0C0D43E7D8@atuin.in.mat.cc> <8637tvyzpe.fsf@FreeBSD.org> <1927902E41BBF231A0EF6A54@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========B74432108A7550EFCE8B========== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline tl;dr: The qa script work as intented, it caught some software doing something stupid. +--On 18 janvier 2016 16:18:40 +0100 Mathieu Arnold <mat@FreeBSD.org> wrote: | | | +--On 18 janvier 2016 08:00:29 -0200 Raphael Kubo da Costa | <rakuco@FreeBSD.org> wrote: || Mathieu Arnold <mat@FreeBSD.org> writes: || ||> +--On 17 janvier 2016 23:12:36 +0100 Raphael Kubo da Costa ||> <rakuco@FreeBSD.org> wrote: ||> |> For these, if the non-linking is intentional, and not needed, ||> |> ignore the ***WARNING***. ||> | ||> | Right. If linking against libperl.so and not linking against it are ||> | both fine, does it still make sense to have that stage-qa check? ||> ||> There is a stage-qa check because if you link against libperl.so, you ||> MUST have rpath set to the path of libperl.so, it happens if the port is ||> doing what Perl should be doing and getting it wrong. Also, sometime, ||> you don't link with libperl.so, and it's a mistake, and it should be. ||> ||> There are a few cases where it's not needed, but when I added the qa ||> check when I changed libperl.so to be versionned, out of all the ports ||> that install .so in PERL_ARCH, there were, say, 3 or 4 that had a .so ||> that did not need to be linked with libperl.so. || || How about making the "not linked with libperl.so.x.y" warning non-fatal || then? Right now I cannot just ignore it as suggested because it makes || the script exit with a non-zero error code. | | I just had a look at the commit, and the qa script is right. The author | is wrong, the .so contains Perl code and must be linked with libperl.so. | It must be linked with it so that when the major Perl version is changed | (like 5.20 -> 5.22 that is happening soon(tm)) the link allows pkg to | know that the package needs to be reinstalled so that it continues to | work. | || While here: there's a FIXME comment in this part that talks about || changing the linkage detection logic, but it does not specify what || should be changed. Do you have more information? I could try to fix both || issues and send a patch for review. | | I forgot about the FIXME. It works as intented right now, I'll have a look | at it later. -- Mathieu Arnold --==========B74432108A7550EFCE8B========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJWnQYhXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I0rYP/3CGgbuqwLJxTUT1rdoCv0Wj zP8tJisO6lE6vXHEJ9VRvJzoeY4AYhkEdWNNyYkxkJh7xh7jQAe2R/YzUYkjXIBp EQPNQqrwds9JB2Y2y25fNXrw7Fi1iDVK8f5+WkO9/ry8oQlNyeVwtAwhzyGpKFpP RiLkzyhecNW/cCYbg38FGjcCdzMvpVVn5bJfHP0j/7d/fCvPRyOAzJ3X4RF3Rqbs uhyL5HMb8AZgxyi68NHWs6RWhNKe72MfkkbG03wcCMWh5BYfR7S7VODxI7UN/IQK o1XwE/hV368khxKcZL65b2GlL9yn8C3dZoRs6ZvQsviFJ7sXnHMEw5OuIkFue8Dl eB8pEwGb43Wy2TBENP5iiepzz1gUJaQ/x5/hj78K06LdcqYXeCDrjveDfOb6+ziE 83Oj8jdJn9PSIxWBVhvKgd59BEb3z9G/3BTrrqRpGHuHLt5321y7XLo6VCAcI/2k Kf0+0jvLJ/4RFlo+hBMXL8OeSq9K98St2vIzR0/G+XLgpsr7xIh+aeVkfLldmz64 IAV2YuQn03lQvCogAQ59yBr2/G7wxTZScy1EH67akFcyBhXSAub6K2yMSzGyUXBC Dei7Cx1xxRgCiD25k0l3TLOB08h/SBm3EofrJ80LyRrPEufXo6TqdhrhOce0wGHQ G8Vc8DeoMLq3PSieL59J =rcRf -----END PGP SIGNATURE----- --==========B74432108A7550EFCE8B==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C3873737817287E61167F372>