Date: Sat, 8 Nov 2014 16:11:44 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274274 - head/sys/net Message-ID: <17FD4DFD-D5A0-45DC-B7AC-CD44EF49B33E@FreeBSD.org> In-Reply-To: <20141108160304.GQ1031@FreeBSD.org> References: <201411080723.sA87N2hx046823@svn.freebsd.org> <8B3F77C9-C79D-4303-ADB6-310B3928D51C@FreeBSD.org> <20141108160304.GQ1031@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08 Nov 2014, at 16:03 , Gleb Smirnoff <glebius@FreeBSD.org> wrote: > On Sat, Nov 08, 2014 at 03:06:20PM +0000, Bjoern A. Zeeb wrote: > B> > Modified: head/sys/net/if.c > B> > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > B> > --- head/sys/net/if.c Sat Nov 8 06:43:33 2014 = (r274273) > B> > +++ head/sys/net/if.c Sat Nov 8 07:23:01 2014 = (r274274) > B> > @@ -265,13 +265,12 @@ ifnet_byindex_ref(u_short idx) > B> > * Allocate an ifindex array entry; return 0 on success or an = error on > B> > * failure. > B> > */ > B> > -static int > B> > -ifindex_alloc_locked(u_short *idxp) > B> > +static u_short > B>=20 > B> That feels like going backwards; we should really make sure we = can support ifindexes >> 64k >=20 > This isn't backwards, since if_index was u_short before the commit. >=20 > I will take into account your wish and see if we can enlarge if_index. Yeah, I think we fixed most of the APIs to be able to extend it and = brooks had a spare a while ago I think. Last time this was discussed the leaning was to go straight to uint64_t = to avoid any problems for the next two decades ;-) /bz =97=20 Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 1983
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17FD4DFD-D5A0-45DC-B7AC-CD44EF49B33E>