Date: Thu, 08 May 2014 15:15:16 -0700 (PDT) From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: sunpoet@FreeBSD.org Subject: ports/189487: [PATCH] astro/cfitsio: Actually make -lz be passed to the linker. Message-ID: <536c01f4.8a9d700a.0996.48cf@mx.google.com> Resent-Message-ID: <201405082220.s48MK1s6067061@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 189487 >Category: ports >Synopsis: [PATCH] astro/cfitsio: Actually make -lz be passed to the linker. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu May 08 22:20:01 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Raphael Kubo da Costa >Release: FreeBSD 11.0-CURRENT amd64 >Organization: >Environment: System: FreeBSD orwell 11.0-CURRENT FreeBSD 11.0-CURRENT #9 r264665: Fri Apr 18 23:19:11 EEST >Description: The way the port's build system is set up, changing LDFLAGS does not have any effect. Instead, one should specify additional libraries at configure-time by setting LIBS, which is then passed to the linker at build time and is also used in the port's .pc file. This should unbreak astro/wcslib when this port is installed, as it the detection is currently failing because of missing zlib symbols in the test programs built at configure-time. Port maintainer (sunpoet@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN) >How-To-Repeat: >Fix: --- cfitsio-3.360.patch begins here --- Index: Makefile =================================================================== --- Makefile (revision 353360) +++ Makefile (working copy) @@ -3,7 +3,7 @@ PORTNAME= cfitsio PORTVERSION= 3.360 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= astro MASTER_SITES= http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/ \ http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/oldvers/ \ @@ -23,10 +23,10 @@ ALL_TARGET= libcfitsio.a shared CFLAGS+= -I${INCLUDEDIR} +CONFIGURE_ENV+= LIBS="-L${LIBDIR} -lz" CONFIGURE_ARGS= ac_cv_prog_FC=f2c GNU_CONFIGURE= yes MAKE_ARGS= ZLIB_SOURCES="zlib/zcompress.c zlib/zuncompress.c" -LDFLAGS+= -L${LIBDIR} -lz USE_LDCONFIG= yes USES= pkgconfig WRKSRC= ${WRKDIR}/${PORTNAME} --- cfitsio-3.360.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?536c01f4.8a9d700a.0996.48cf>