Date: Sun, 17 Dec 2000 14:59:18 -0800 From: "Crist J. Clark" <cjclark@reflexnet.net> To: Doug Barton <DougB@gorean.org> Cc: Poul-Henning Kamp <phk@FreeBSD.ORG>, current@FreeBSD.ORG Subject: Re: test/review: /dev/console logging patch Message-ID: <20001217145918.K96105@149.211.6.64.reflexcom.com> In-Reply-To: <3A3D2CFD.8572F575@gorean.org>; from DougB@gorean.org on Sun, Dec 17, 2000 at 01:15:41PM -0800 References: <20743.977081023@critter> <3A3D2CFD.8572F575@gorean.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 17, 2000 at 01:15:41PM -0800, Doug Barton wrote: > Poul-Henning Kamp wrote: > > > > This patch is for the printf(9), log(9) & /dev/console stuff. > > The result is that you can watch the output from /etc/rc in > > your /var/log/messages. > > This works spectacularly for me on a UP -current with up to date > sources. The only nit I have is that it doesn't understand lines that > don't end in a newline very well (such as echo -n, or a printf with no > \n), so it produces log output like this: > > Dec 17 13:00:24 <console.info> Master /boot/kernel/kernel: /dev/da1s1a: > Dec 17 13:00:24 <console.info> Master /boot/kernel/kernel: FILESYSTEM > CLEAN; SKIPPING CHECKS > Dec 17 13:00:24 <console.info> Master /boot/kernel/kernel: /dev/da1s1a: > Dec 17 13:00:24 <console.info> Master /boot/kernel/kernel: clean, 42202 > free > Dec 17 13:00:24 <console.info> Master /boot/kernel/kernel: (154 frags, > 5256 blocks, 0.2% fragmentation) > > and > > Dec 17 13:00:26 <console.info> Master /boot/kernel/kernel: Doing > additional network setup: > Dec 17 13:00:26 <console.info> Master /boot/kernel/kernel: ntpdate > Dec 17 13:00:26 <console.info> Master /boot/kernel/kernel: ntpd > Dec 17 13:00:27 <console.info> Master /boot/kernel/kernel: portmap > Dec 17 13:00:27 <console.info> Master /boot/kernel/kernel: . > > Now, the first isn't a big deal, but the second is a little confusing. > Would there be any harm to changing the dots to something more > meaningful, like "Done with additional network setup" on its own line? I > seriously considered that when I was working on the echo's last night, > but I didn't want to be too revolutionary. :) s/\./(done)/ Or maybe '(finished)'? -- Crist J. Clark cjclark@alum.mit.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001217145918.K96105>