Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Dec 2001 12:39:12 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Ian Dowse <iedowse@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   RE: cvs commit: src/sys/nfs nfs_common.c
Message-ID:  <XFMail.011231123912.jhb@FreeBSD.org>
In-Reply-To: <200112310656.fBV6uVT21497@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 31-Dec-01 Ian Dowse wrote:
> iedowse     2001/12/30 22:56:31 PST
> 
>   Modified files:
>     sys/nfs              nfs_common.c 
>   Log:
>   When the old nfsm_adv() macro was moved to nfsm_adv_xx(), a '>='
>   must have been inadvertently changed to '>'. This broke nfsm_adv()
>   in the case where the advancement count is equal to the amount of
>   data remaining in the current mbuf. Instead of moving the current
>   position N bytes forward, nfs_adv() could end up moving it back to
>   N bytes from the start of the mbuf data.
>   
>   This should fix the client-side readdirplus problems that have been
>   reported since September.

Wow!  Nice catch.  Those 1 character bugs always suck. :)

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011231123912.jhb>