Date: Wed, 5 Feb 2014 12:09:32 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r342546 - head/devel/sourcenav Message-ID: <20140205120932.GA24764@FreeBSD.org> In-Reply-To: <201402041603.s14G3E8O035913@svn.freebsd.org> References: <201402041603.s14G3E8O035913@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 04, 2014 at 04:03:14PM +0000, Pietro Cerutti wrote: > New Revision: 342546 > URL: http://svnweb.freebsd.org/changeset/ports/342546 > QAT: https://qat.redports.org/buildarchive/r342546/ > > post-install: > - ${LN} -s ${PREFIX}/sourcenav/bin/snavigator ${PREFIX}/bin/snavigator > + ${LN} -s ${PREFIX}/sourcenav/bin/snavigator ${STAGEDIR}${PREFIX}/bin/snavigator Quoting our own wiki.freebsd.org/ports/StageDir: "When creating a symlink, prepend ${STAGEDIR} to the target path only (and generally try to avoid using absolute paths in source). [...] Note that source of ${PREFIX}/lib/libfoo.so.42, while seemingly okay, could be in fact incorrect, since absolute path can potentially point to a wrong location, e.g. when remote filesystem (with installed package) is mounted via NFS under non-root mount point. Relative paths are less fragile (and often much shorter)." No need to immediately correct this particular commit (I plan to massively clean up lots of style bugs that were introduced during stage conversion, once it's over); just a note for the future. :) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140205120932.GA24764>