Date: Sat, 19 Oct 2002 09:54:11 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Maxim Sobolev <sobomax@FreeBSD.ORG> Cc: hackers@FreeBSD.ORG, dillon@FreeBSD.ORG Subject: Re: Patch to allow a driver to report unrecoverable write errors to the buf layer Message-ID: <28472.1035014051@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 18 Oct 2002 20:45:25 %2B0300." <3DB048B5.21097613@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <3DB048B5.21097613@FreeBSD.org>, Maxim Sobolev writes: >Hi folks, > >I noticed that FreeBSD buf/bio subsystem has one very annoying problem >- once the write request is ejected into it, and write operation >failed, there seemingly no way valid to tell the layer to drop the >buffer. Instead, it retries the attempt over and over again, until >reboot, even though originator of request (usually vfs layer) was >already notified about failure and propagated error condition to the >underlying user-lever program. Yes, I noticed that appeared at some time. That misfeature should be removed in toto. If a retry can solve the issue, it's the drivers responsibility to retry as much as makes sense and then fail if it doesn't work. Neither the buf nor the bio layer should get involved in those retries. If you really want to change the behaviour here, you should add a flag on the buf going down, saying "Never, ever retry". -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?28472.1035014051>