Date: Sun, 17 Feb 2013 04:25:22 +0100 From: Davide Italiano <davide@freebsd.org> To: hiren panchasara <hiren.panchasara@gmail.com> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: Running out of bits p_flag (sys/sys/proc.h) Message-ID: <CACYV=-EZ2Sr9STgCnUj%2B-xkWPKPV8Cz4-FhrVMY4v0VNCU_Jvg@mail.gmail.com> In-Reply-To: <CALCpEUF0UwmEa4T3gyAH=YKDYczxZgUjtdjGZikNU4yTd=KKDg@mail.gmail.com> References: <CALCpEUF0UwmEa4T3gyAH=YKDYczxZgUjtdjGZikNU4yTd=KKDg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 17, 2013 at 2:58 AM, hiren panchasara
<hiren.panchasara@gmail.com> wrote:
> With revision=246484, it seems we have hit the limit.
> At $WORK we have one more flag and to accommodate that we need to bump this up.
>
> Can p_flag be bumped up to u_long?
>
> Index: proc.h
> ===================================================================
> --- proc.h (revision 245937)
> +++ proc.h (working copy)
> @@ -497,7 +497,7 @@
> * The following don't make too much sense.
> * See the td_ or ke_ versions of the same flags.
> */
> - int p_flag; /* (c) P_* flags. */
> + u_long p_flag; /* (c) P_* flags. */
> enum {
> PRS_NEW = 0, /* In creation */
> PRS_NORMAL, /* threads can be run. */
>
> Thanks,
> Hiren
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
I see at least two problems here:
- The change you propose may result in a KBI breakage.
- sizeof(unsigned long) == 4 on some archs, e.g. my i386 Atom, which
makes the change uneffective.
Thanks,
Davide
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACYV=-EZ2Sr9STgCnUj%2B-xkWPKPV8Cz4-FhrVMY4v0VNCU_Jvg>