Date: Wed, 29 Jun 2011 18:34:31 GMT From: David Demelier <demelier.david@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/158501: [patch] multimedia/mplayer: faad dependency problem Message-ID: <201106291834.p5TIYVHX064241@red.freebsd.org> Resent-Message-ID: <201106291840.p5TIe7Vi022436@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 158501
>Category: ports
>Synopsis: [patch] multimedia/mplayer: faad dependency problem
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 29 18:40:06 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: David Demelier
>Release: 8.2-STABLE
>Organization:
>Environment:
FreeBSD Melon.malikania.fr 8.2-STABLE FreeBSD 8.2-STABLE #2: Mon Jun 27 14:05:45 CEST 2011 root@Melon.malikania.fr:/usr/obj/usr/src/sys/Melon amd64
>Description:
The mplayer port automatically links to faad if it's installed (autoconf feature). Thus if you have faad installed because of an other port dependency and you'll remove this port faad will be marked as leave but mplayer still need it.
This patch prevents this case and user must specify itself the action or not. I choose the ON option by default.
>How-To-Repeat:
>Fix:
--- mplayer.diff begins here ---
--- Makefile 2011-06-29 20:28:54.000000000 +0200
+++ Makefile.orig 2011-06-29 20:13:01.000000000 +0200
@@ -7,7 +7,7 @@
PORTNAME= mplayer
PORTVERSION= ${MPLAYER_PORT_VERSION}
-PORTREVISION= 3
+PORTREVISION= 2
COMMENT= High performance media player supporting many formats
.include "${.CURDIR}/Makefile.shared"
@@ -31,7 +31,6 @@
OPTIONS+= RTC "Add support for kernel real time clock timing" off
OPTIONS+= ARTS "Enable KDE sound system support" off
OPTIONS+= ESOUND "Enable GNOME esound support" off
-OPTIONS+= FAAD "FAAD AAC and MP4 audio decoder support" on
OPTIONS+= JACK "Enable JackIt audio server support" off
OPTIONS+= NAS "Enable NAS sound server support" off
OPTIONS+= OPENAL "Enable OpenAL sound support" off
--- Makefile.options.orig 2011-06-29 20:12:43.000000000 +0200
+++ Makefile.options 2011-06-29 20:15:55.000000000 +0200
@@ -109,6 +109,12 @@
CONFIGURE_ARGS+= --disable-live
.endif
+.if defined(WITH_FAAD)
+LIB_DEPENDS+= faad.2:${PORTSDIR}/audio/faad
+.else
+CONFIGURE_ARGS+= --disable-faad
+.endif
+
.if defined(WITH_JACK)
LIB_DEPENDS+= jack.0:${PORTSDIR}/audio/jack
.else
--- mplayer.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201106291834.p5TIYVHX064241>