Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Dec 2012 01:09:33 +0100
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/174844: [PATCH] cad/electric-ng: update to 9.03, take maintainership, added licence, icon, desktop entry
Message-ID:  <20121231000936.F0698536@hub.freebsd.org>
Resent-Message-ID: <201212310010.qBV0A0Dc037110@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         174844
>Category:       ports
>Synopsis:       [PATCH] cad/electric-ng: update to 9.03, take maintainership, added licence, icon, desktop entry
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 31 00:10:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC
>Description:
- Update to 9.03
- Take maintainership

Makefile changed:
+DIST_SUBDIR=	${PORTNAME}
+COMMENT=	Sophisticated VLSI design system
+LICENSE=	GPLv3
+		share/pixmaps/${PORTNAME}.png
+OPTIONS_DEFINE=	BSH JYTHON SCALA 3D JMF AXIS RUSSIAN
+DESKTOP_ENTRIES=
+post-extract:

Changed and refined:
 do-install:
 pkg-descr

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: update, diff: ports)
>How-To-Repeat:

portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
WARN: Makefile: "DISTFILES" has to appear earlier.
0 fatal errors and 3 warnings found.

WARN: Makefile: using hyphen in PORTNAME. because is used
PORTNAME=	electric-ng
By using PKGNAMEPREFIX and/or PKGNAMESUFFIX the Makefile is very complicated.

WARN: Makefile: "DISTFILES" because is used as before
DISTFILES=	${PLUGINS:S,$,.jar,:S,$,:1,} ${DISTNAME}${EXTRACT_SUFX}

port test: clean

>Fix:

--- electric-ng-9.03.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/cad/electric-ng/Makefile ./Makefile
--- /usr/ports/cad/electric-ng/Makefile	2012-12-12 01:01:06.000000000 +0100
+++ ./Makefile	2012-12-31 00:54:19.000000000 +0100
@@ -3,64 +3,78 @@
 #
 
 PORTNAME=	electric-ng
-PORTVERSION=	8.11
-PORTREVISION=	0
+PORTVERSION=	9.03
 CATEGORIES=	cad java
 MASTER_SITES=	${MASTER_SITE_GNU} \
 		http://www.staticfreesoft.com/:1
 MASTER_SITE_SUBDIR=	${PORTNAME:S/-ng//}
 DISTNAME=	electric-${PORTVERSION}
 EXTRACT_SUFX=	.jar
-EXTRACT_ONLY=
+DIST_SUBDIR=	${PORTNAME}
+EXTRACT_ONLY=	#empty
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A sophisticated VLSI design system
+MAINTAINER=	nemysis@gmx.ch
+COMMENT=	Sophisticated VLSI design system
+
+LICENSE=	GPLv3
 
 USE_JAVA=	yes
 JAVA_VERSION=	1.6+
 NO_BUILD=	yes
+
 PLIST_FILES=	%%JAVAJARDIR%%/${JARFILE} \
-		bin/electric-ng
+		bin/${PORTNAME} \
+		share/pixmaps/${PORTNAME}.png
+
 SUB_LIST+=	LIBFILES="${LIBFILES}" \
 		JARFILE="${JARFILE}"
+
 SUB_FILES=	electric-ng
 
-OPTIONS_DEFINE=	BSH 3D IRSIM ANIM AXIS RUSSIAN
+OPTIONS_DEFINE=	BSH JYTHON SCALA 3D JMF AXIS RUSSIAN
+
 BSH_DESC=	Enable embedded java interpreter via BSH
+JYTHON_DESC=	Enable Python for the Java Platform
+SCALA_DESC=	Enable Scala Programming Language
 3D_DESC=	Enable 3D visualization via Java3D
-IRSIM_DESC=	Install IRSIM plugin
-ANIM_DESC=	Install 3D animation plugin
+JMF_DESC=	Enable Java Media Framework
 AXIS_DESC=	Install 3D Axis Controller plugin
 RUSSIAN_DESC=	Install Russian manual
 
 JARFILE=	${DISTNAME}${EXTRACT_SUFX}
 J3DLIB=		${LOCALBASE}/share/java/java3d/jar/j3dcore.jar
-PLUGINDIR=	${PREFIX}/libexec/electric/
+PLUGINDIR=	${PREFIX}/libexec/electric
+
+DESKTOP_ENTRIES="Electric" "${COMMENT}" "${PORTNAME}" \
+		"${PORTNAME}" "Development;Electronics;Engineering;" ${FALSE}
 
 .include <bsd.port.options.mk>
 
+post-extract:
+	@(cd ${DISTDIR}/${DIST_SUBDIR} && ${UNZIP_CMD} -d ${WRKDIR} electric-${PORTVERSION}.jar \
+			com/sun/electric/tool/user/help/helphtml/iconplug.png)
+
 .if ${PORT_OPTIONS:MBSH} || exists(${JAVALIBDIR}/bsh.jar)
 RUN_DEPENDS+=	${JAVALIBDIR}/bsh.jar:${PORTSDIR}/lang/bsh
 LIBFILES+=	${JAVALIBDIR}/bsh.jar
 .endif
 
-.if ${PORT_OPTIONS:MAXIS}
-WITH_3D=	yes
-PLUGINS+=	electricJava3D-8.11
+.if ${PORT_OPTIONS:MJYTHON}
+RUN_DEPENDS+=	jython:${PORTSDIR}/lang/jython
 .endif
 
-.if ${PORT_OPTIONS:MANIM}
-WITH_3D=	yes
-RUN_DEPENDS+=	${JAVALIBDIR}/jmf.jar:${PORTSDIR}/java/jmf
-PLUGINS+=	electricJMF-8.11
+.if ${PORT_OPTIONS:MSCALA}
+RUN_DEPENDS+=	scala:${PORTSDIR}/lang/scala
 .endif
 
 .if ${PORT_OPTIONS:M3D} || exists(${J3DLIB})
-RUN_DEPENDS+=	${J3DLIB}:${PORTSDIR}/java/java3d
+RUN_DEPENDS+=	java3d:${PORTSDIR}/java/java3d
 .endif
 
-.if ${PORT_OPTIONS:MIRSIM}
-PLUGINS+=	electricIRSIM-8.11
+.if ${PORT_OPTIONS:MAXIS}
+WITH_3D=	yes
+RUN_DEPENDS+=	${JAVALIBDIR}/jmf.jar:${PORTSDIR}/java/java3d
+PLUGINS+=	electricJava3D-8.11
 .endif
 
 .if ${PORT_OPTIONS:MRUSSIAN}
@@ -75,13 +89,14 @@
 
 do-install:
 	@${MKDIR} ${JAVAJARDIR}
-	${INSTALL_DATA} ${DISTDIR}/${JARFILE} ${JAVAJARDIR}
+	${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/${JARFILE} ${JAVAJARDIR}
 	${INSTALL_SCRIPT} ${WRKDIR}/electric-ng ${PREFIX}/bin
+	${INSTALL_DATA} ${WRKDIR}/com/sun/electric/tool/user/help/helphtml/iconplug.png \
+		${PREFIX}/share/pixmaps/${PORTNAME}.png
 
 .if defined(PLUGINS)
-	# Install plugins
-	@${MKDIR} ${PLUGINDIR}/
-	${INSTALL_DATA} ${PLUGINS:S,^,${DISTDIR}/,:S,$,.jar,} ${PLUGINDIR}/
+	@${MKDIR} ${PLUGINDIR}
+	${INSTALL_DATA} ${PLUGINS:S,^,${DISTDIR}/${DIST_SUBDIR}/,:S,$,.jar,} ${PLUGINDIR}
 .endif
 
 .include <bsd.port.mk>
diff -ruN --exclude=CVS /usr/ports/cad/electric-ng/distinfo ./distinfo
--- /usr/ports/cad/electric-ng/distinfo	2012-12-05 00:44:25.000000000 +0100
+++ ./distinfo	2012-12-31 00:27:41.000000000 +0100
@@ -1,10 +1,6 @@
-SHA256 (electricJava3D-8.11.jar) = e1b7a24036300313416ce554b4fb345bc69fed7b41df89302e86b5bcbfacf066
-SIZE (electricJava3D-8.11.jar) = 5358
-SHA256 (electricJMF-8.11.jar) = 17a88fcd346500d2daaa41015df2d13c78189c610b789c76f25da3165d2362f4
-SIZE (electricJMF-8.11.jar) = 13480
-SHA256 (electricIRSIM-8.11.jar) = a06a4e7d1701ef287137c7eefac29af764f314ef4a3d86b8699965be1d0dea44
-SIZE (electricIRSIM-8.11.jar) = 151501
-SHA256 (electricRussianManual-8.11.jar) = a9b76748b65ded72412c949514e5c240ffa0233f69451887853ba71e5f268550
-SIZE (electricRussianManual-8.11.jar) = 1931050
-SHA256 (electric-8.11.jar) = 6c78d5f149e29bd14bfeb0dbbaa941b9d4e60c9417a427f6ad2055d7cd42b1af
-SIZE (electric-8.11.jar) = 17329083
+SHA256 (electric-ng/electricJava3D-8.11.jar) = e1b7a24036300313416ce554b4fb345bc69fed7b41df89302e86b5bcbfacf066
+SIZE (electric-ng/electricJava3D-8.11.jar) = 5358
+SHA256 (electric-ng/electricRussianManual-8.11.jar) = a9b76748b65ded72412c949514e5c240ffa0233f69451887853ba71e5f268550
+SIZE (electric-ng/electricRussianManual-8.11.jar) = 1931050
+SHA256 (electric-ng/electric-9.03.jar) = 55e5a5e58a55c048c9ae67b4066dd7f8080d20cb708a147c7570b352be36e380
+SIZE (electric-ng/electric-9.03.jar) = 29716607
diff -ruN --exclude=CVS /usr/ports/cad/electric-ng/pkg-descr ./pkg-descr
--- /usr/ports/cad/electric-ng/pkg-descr	2012-12-05 00:44:25.000000000 +0100
+++ ./pkg-descr	2012-12-30 17:27:40.000000000 +0100
@@ -1,31 +1,16 @@
-Electric is a sophisticated electrical CAD system that can handle
-many forms of circuit design, including:
- - Custom IC layout (ASICs) 
- - Schematic drawing 
- - Hardware description language specifications 
+A state-of-the-art computer-aided design system for VLSI circuit design.
 
-Electric has these CAD operations:  
- - Design rule checking
- - Electrical rule checking
- - Simulation and simulation interface (many options)
- - Generation (ROMs, PLAs, Pad Frames, etc.)
- - Compaction
- - Routing 
- - VHDL compilation
- - Silicon compilation
- - Network consistency checking (LVS)
- - Logical Effort analysis
- - Project Management
-       
-Electric can display these types of design:
- - MOS (many CMOS and nMOS variations)
- - Bipolar and BiCMOS
- - Schematics and printed circuits
- - Digital filters, Temporal logic
- - Artwork
+Electric designs MOS and bipolar integrated circuits, printed-circuit-boards,
+or any type of circuit you choose. It has many editing styles including
+layout, schematics, artwork, and architectural specifications.
 
-For real functionality, one should consider installing
-support simulation software such as cad/spice.
+A large set of tools is available including design-rule checkers, simulators,
+routers, layout generators, and more.
 
-Author:	Static Free Software & Sun Microsystems, Inc.
-WWW:	http://www.staticfreesoft.com/
+Electric interfaces to most popular CAD specifications including
+EDIF, LEF/DEF, VHDL, CIF and GDS.
+
+The most valuable aspect of Electric is its layout-constraint system,
+which enables top-down design by enforcing consistency of connections.
+
+WWW: http://www.staticfreesoft.com/
--- electric-ng-9.03.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121231000936.F0698536>