Date: Tue, 13 Apr 2010 23:19:04 -0700 From: John Prather <john.c.prather@gmail.com> To: freebsd-ports@freebsd.org Subject: State of gmime (mail/gmime24) Message-ID: <t2w25aa95031004132319l9e66a7e0j87d0cbab4f8620c6@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
Hello, I've been maintaining a port which provides a plugin for Pidgin (net-im/pidgin-sipe), which has recently introduced the option to build a telepathy plugin in addition to or instead of the purple plugin. Building the telepathy plugin causes gnu configure to require gmime 2.4 >=3D 2.4.16 (mail/gmime24 is 2.4.10 currently) or gmime 2.6 >=3D 2.5.2 (seems to be no 2.6 port yet). I've found that I can easily patch one of the bug fixes I found (https://bugzilla.gnome.org/show_bug.cgi?id=3D613653#c8) that the sipe developers deemed necessary into the 2.4.10 port, however I'm wary of going crazy with freebsd patches for 2.4.10 if we are going to have 2.4.16 out in the near future, or 2.6 >=3D 2.5.2 made available. =A0Also, there may be other important bug fixes, though the others which i found that the sipe developers were concerned with were all related to building on Windows. Do we feel that patching 2.4.10 with relatively simple patches would be a decent approach, or should we wait for either 2.4.16 release and the corresponding port update or 2.6 to be added into ports? =A0I partly feel we should wait for the correct versions to be made available, but it seems silly to wait weeks or months or more and deal with someone having to port a whole new release over such a simple fix. Here is what the patches look like which seem to apply nicely to 2.4.10 in mail/gmime24: (i'm sure the email turned tabs to spaces, but you can see the gist of it. I can post the unmangled patch files somewhere if they are desired) [root@bsdlaptop /usr/ports/mail/gmime24]# cat files/patch-gmime_gmime.c *** gmime/gmime.c.orig =A0Tue Apr 13 22:45:25 2010 --- gmime/gmime.c =A0 =A0 =A0 Tue Apr 13 22:46:09 2010 *************** *** 141,147 **** =A0{ =A0 =A0 =A0 =A0if (--initialized) =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return; ! =A0 =A0 =A0 =A0g_mime_charset_map_shutdown (); =A0 =A0 =A0 =A0g_mime_iconv_shutdown (); =A0} --- 141,148 ---- =A0{ =A0 =A0 =A0 =A0if (--initialized) =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return; ! ! =A0 =A0 =A0 g_mime_object_shutdown(); =A0 =A0 =A0 =A0g_mime_charset_map_shutdown (); =A0 =A0 =A0 =A0g_mime_iconv_shutdown (); =A0} [root@bsdlaptop /usr/ports/mail/gmime24]# cat files/patch-gmime_gmime-object.c *** gmime/gmime-object.c.orig =A0 Tue Apr 13 22:46:38 2010 --- gmime/gmime-object.c =A0 =A0 =A0 =A0Tue Apr 13 22:48:48 2010 *************** *** 1061,1068 **** =A0 =A0 =A0 =A0g_free (bucket); =A0} ! static void ! type_registry_shutdown (void) =A0{ =A0 =A0 =A0 =A0g_hash_table_foreach (type_hash, type_bucket_foreach, NULL); =A0 =A0 =A0 =A0g_hash_table_destroy (type_hash); --- 1061,1068 ---- =A0 =A0 =A0 =A0g_free (bucket); =A0} ! void ! g_mime_object_shutdown (void) =A0{ =A0 =A0 =A0 =A0g_hash_table_foreach (type_hash, type_bucket_foreach, NULL); =A0 =A0 =A0 =A0g_hash_table_destroy (type_hash); *************** *** 1075,1080 **** =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return; =A0 =A0 =A0 =A0type_hash =3D g_hash_table_new (g_mime_strcase_hash, g_mime_= strcase_equal); - - =A0 =A0 =A0 g_atexit (type_registry_shutdown); =A0} --- 1075,1078 ---- [root@bsdlaptop /usr/ports/mail/gmime24]# cat files/patch-gmime_gmime-objec= t.h *** gmime/gmime-object.h.orig =A0 Tue Apr 13 22:49:01 2010 --- gmime/gmime-object.h =A0 =A0 =A0 =A0Tue Apr 13 22:49:51 2010 *************** *** 94,99 **** --- 94,100 ---- =A0GType g_mime_object_get_type (void); =A0void g_mime_object_register_type (const char *type, const char *subtype, GType object_type); + void g_mime_object_shutdown (void); =A0GMimeObject *g_mime_object_new (GMimeContentType *content_type); =A0GMimeObject *g_mime_object_new_type (const char *type, const char *subty= pe); -- John Prather
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?t2w25aa95031004132319l9e66a7e0j87d0cbab4f8620c6>